-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meta-ticket: Clean up src/setup.py to bring it to standard setuptools behavior #21508
Comments
Dependencies: #20596 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:8
By which you mean the makefile in |
This comment has been minimized.
This comment has been minimized.
comment:9
Yes -- I've clarified it in the description. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:13
Definitely keep in touch with me as a point of contact on any work you do on this--I know distutils + setuptools from top to bottom. |
This comment has been minimized.
This comment has been minimized.
comment:15
Let me just say that I consider #21613 not an important step towards this task ("... standard distutils behavior"). The present task ticket (#21508) is concerned with getting the behavior of |
comment:16
Except it is pretty non-standard for it to have non-trivial side-effects (e.g. running a subprocess that generates files) unconditionally. Behavior-wise that should only happen when it's actually important for that to happen, such as during the build command. |
comment:17
Replying to @embray:
I agree that it should happen during the build command. |
comment:18
I will work on #21613, and you'll see it's not that big a deal. |
comment:20
Yep. I don't think there will be significant conflicts, but I can make those tickets dependencies of #21613 and ensure any work I do there integrates well with the others before suggesting it to be merged. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:35
Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date. |
Sub-tasks:
In particular,
src/setup.py --help
should return immediately.src/setup.py clean
should not build anything but just clean (and everything that is now done bymake clean
in thesrc
directory should be done by it; see make sagelib a script package #29411)Also the following should be done:
src/setup.py
,src/fpickle_setup.py
tosage_setup
src/setup.py sdist
)src/setup.py
respect--build-base
and--inplace
, independent ofSAGE_CYTHONIZED
src/setup.py
respects--install-base
and--root
src/setup.py
setup_requires
) onpkgconfig
,numpy
#30580sage_setup
: Remove import-time dependency (setup_requires
) onpkgconfig
,numpy
Also see:
package_data
instead ofdata_files
in setup.pyCC: @jdemeyer @vbraun @embray @nexttime @kiwifb @williamstein @mezzarobba @dimpase @jhpalmieri
Component: build
Issue created by migration from https://trac.sagemath.org/ticket/21508
The text was updated successfully, but these errors were encountered: