-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade polymake to version 3.1 #22513
Comments
Branch: u/moritz/polymake-beta |
comment:2
The tar ball, which should be put in the folder |
Changed branch from u/moritz/polymake-beta to none |
comment:3
Before you deleted the branch, I pulled it and built successfully on Mac OS. |
Branch: u/moritz/polymake-beta |
New commits:
|
Commit: |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Reviewer: Matthias Koeppe |
comment:8
This package completely breaks pypolymake. Don't you want to make a different package? |
comment:9
Moreover, it is not nice to package yourself upstream. I pushed Moritz to make this package for testing purposes. I am very much against its inclusion in Sage. |
comment:10
OK, I agree |
comment:11
Also, the Singular build seems to fail with this beta version of polymake installed. |
comment:12
Replying to @mkoeppe:
For the record, this can be fixed with diff --git a/build/pkgs/singular/spkg-install b/build/pkgs/singular/spkg-install
index 373bd0852b..b172b0ec1f 100755
--- a/build/pkgs/singular/spkg-install
+++ b/build/pkgs/singular/spkg-install
@@ -93,6 +93,7 @@ config()
--with-ntl="$SAGE_LOCAL" \
--with-flint="$SAGE_LOCAL" \
--enable-gfanlib \
+ --disable-polymake \
--enable-Singular \
--enable-factory \
--disable-doc \ |
comment:13
(this fix to Singular is #22606.) |
Dependencies: #22606 |
comment:15
This new version also breaks #22683. Apparently polymake has changed its mind about some important properties:
|
comment:16
Polymake 3.1 was just released. We should repurpose this ticket for the upgrade. Vincent -- objections to upgrading (if it builds OK) even if pypolymake is not ready yet for that version? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:19
A possible upstream issue: |
Changed branch from u/moritz/polymake-beta to u/mkoeppe/polymake-beta |
comment:21
Replying to @mkoeppe:
It was easy to work around this in #22658. New commits:
|
Changed author from Moritz Firsching to Moritz Firsching, Matthias Koeppe |
comment:23
Simon worked well: all tests of the interface (#22452) pass with this new version of polymake! |
Changed reviewer from Matthias Koeppe to Matthias Koeppe, Vincent Delecroix |
comment:24
(hopefully the beta branch of pypolymake should be close to be working with polymake 3.1) |
Changed branch from u/mkoeppe/polymake-beta to |
With my configuration, the configure script of polymake 3.0 is not working, probably due to a new version of perl:
Let's package the latest version of polymake, 3.1.
To build it for Sage do:
$SAGE_ROOT/upstream/
sage -i polymake
Depends on #22606
CC: @videlec @mkoeppe
Component: packages: experimental
Keywords: days84, polymake
Author: Moritz Firsching, Matthias Koeppe
Branch/Commit:
9f0c6d5
Reviewer: Matthias Koeppe, Vincent Delecroix
Issue created by migration from https://trac.sagemath.org/ticket/22513
The text was updated successfully, but these errors were encountered: