Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cython patch for Cygwin #23004

Closed
jdemeyer opened this issue May 15, 2017 · 9 comments
Closed

Add Cython patch for Cygwin #23004

jdemeyer opened this issue May 15, 2017 · 9 comments
Labels
c: packages: standard p: major / 3 t: enhancement
Milestone
sage-8.0

Comments

@jdemeyer
Copy link
Contributor

This adds the patch from cython/cython#1687

Note that this affects Cygwin only, so it's not a problem for packaging on Linux distributions.

This can give a proper fix #13336 and might help with #21459.

CC: @embray

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: 57e4e0f

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/23004
@jdemeyer jdemeyer added this to the sage-8.0 milestone May 15, 2017
@jdemeyer
Copy link
Contributor Author

Branch: u/jdemeyer/add_cython_patch_for_cygwin

@jdemeyer
Copy link
Contributor Author

New commits:

8fdbccaAdd Cython patch for Cygwin

@jdemeyer
Copy link
Contributor Author

Commit: 8fdbcca

@jdemeyer

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 15, 2017

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

57e4e0fAdd Cython patch for Cygwin

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 15, 2017

Changed commit from 8fdbcca to 57e4e0f

@embray
Copy link
Contributor

embray commented May 16, 2017

comment:4

I've already reviewed the original PR for Cython and confirmed that this does what needs to be done.

@embray
Copy link
Contributor

embray commented May 16, 2017

Reviewer: Erik Bray

@vbraun
Copy link
Member

vbraun commented May 20, 2017

Changed branch from u/jdemeyer/add_cython_patch_for_cygwin to 57e4e0f

@vbraun vbraun closed this as completed in d4d0988 May 20, 2017
@jdemeyer jdemeyer mentioned this issue May 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: standard p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.0
Development

No branches or pull requests
3 participants
@embray @vbraun @jdemeyer