Use patched Cython for farey_symbol

[jdemeyer]

This reverts #13336 and fixes the building of farey_symbol on Cygwin using a Cython patch from #23004.

Depends on #23004

CC: @embray

Component: cython

Author: Jeroen Demeyer

Branch: cd4857d

Reviewer: Erik Bray

Issue created by migration from https://trac.sagemath.org/ticket/23022

[jdemeyer]

Branch: u/jdemeyer/use_patched_cython_for_farey_symbol

[jdemeyer]

New commits:

57e4e0f	Add Cython patch for Cygwin
cd4857d	Use patched Cython for farey_symbol

[jdemeyer]

Commit: cd4857d

[embray]

comment:4

Looks good in principle--testing now.

[embray]

comment:5

Okay, works for me!

[embray]

Reviewer: Erik Bray

[kiwifb]

comment:6

I have a couple of question relevant to sage-on-distro. Ok gentoo because I have a feeling binary distro won't care too much but I do because I make several versions of sage available for building and I need to be sure things will work with at least "current stable" and "current develop" (beta). Therefore I need to know if I need to provide different version of cython depending on the sage version.

• Add Cython patch for Cygwin #23004 says it only affect windows, but with this ticket, is the patch now absolutely needed on other platforms as well?
• If I only provide one version of cython with the patch at Add Cython patch for Cygwin #23004 will sage 7.6 still build?

[jdemeyer]

comment:7

Replying to @kiwifb:

• Add Cython patch for Cygwin #23004 says it only affect windows, but with this ticket, is the patch now absolutely needed on other platforms as well?

No, only on Cygwin.

• If I only provide one version of cython with the patch at Add Cython patch for Cygwin #23004 will sage 7.6 still build?

Yes.

[kiwifb]

comment:8

Thank you for your time Jeroen.

[vbraun]

Changed branch from u/jdemeyer/use_patched_cython_for_farey_symbol to cd4857d

[embray]

comment:10

fbissey--you might be interested in commenting on #21459 though. In that case Jeroen is proposing a solution that requires a patch to Cython that would affect affect downstream packaging. All things being equal, I like his solution best and would prefer to use it. But I don't see a way around the fact that it would break building Sage on other platforms without a patched Cython.

[embray]

Changed commit from cd4857d to none

[kiwifb]

comment:11

Replying to @embray:

fbissey--you might be interested in commenting on #21459 though. In that case Jeroen is proposing a solution that requires a patch to Cython that would affect affect downstream packaging. All things being equal, I like his solution best and would prefer to use it. But I don't see a way around the fact that it would break building Sage on other platforms without a patched Cython.

For the record I am already in the business of providing a patched cython for sage-on-gentoo. I sometimes feel more free than my debian colleagues...

[embray]

comment:12

Okay. Yeah, for Debian it might be more of a problem, and I don't want to make additional pain for that ongoing, and IIUC nearly complete work.