Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polymake 3.4's lrslib detection, add dependency on ppl #27803

Closed
mkoeppe opened this issue May 9, 2019 · 10 comments
Closed

Fix polymake 3.4's lrslib detection, add dependency on ppl #27803

mkoeppe opened this issue May 9, 2019 · 10 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented May 9, 2019

polymake 3.4 has an updated lrslib detection code that fails to recognize the installed lrslib from Sage on macOS.

Depends on #24905

CC: @dimpase [email protected] [email protected] @vbraun

Component: packages: experimental

Author: Matthias Koeppe

Branch/Commit: public/27803-polymake-lrslib-detection @ 5916141

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/27803

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 9, 2019

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 9, 2019

comment:2

Dima - of course, adding --with-lrs="$SAGE_LOCAL" to polymake's configure conflicts with your efforts with spkg-configure.m4.
What should I do?


Last 10 new commits:

666db96Added two missing optional tags
4e91dccChange format of a 'not tested' doc test annotation
05f3e61update docs, as discussed on #24905
53c8ee6Mention libterm-readkey-perl
b613e57Mention libterm-readline-gnu-perl
e5c3249polymake: Mention MOngoDB for polydb
b89376apolymake: Update info on macOS
0c1b044polymake: update MongoDB information for linux distros
2eda6e1polymake: add to fedora instructions
5916141Fix polymake lrslib detection

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 9, 2019

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 9, 2019

Commit: 5916141

@dimpase
Copy link
Member

dimpase commented May 9, 2019

comment:3

Replying to @mkoeppe:

Dima - of course, adding --with-lrs="$SAGE_LOCAL" to polymake's configure conflicts with your efforts with spkg-configure.m4.
What should I do?

No worries, lrs has not been spkg-configurified yet, see #27330 (your help in reviewing there is most welcome, by the way, e.g. all these readline and curses packages...). We should do lrs too, I just opened #27804 for this. So we will need to change that hardcoded value of its prefix to whatever configure finds. Already did this for GMP etc, so no big problem
I gather.

@dimpase
Copy link
Member

dimpase commented May 9, 2019

comment:5

ready for review?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 9, 2019

comment:7

The relevant output (without this patch) from polymake's configure in build/bundled.log:

---- lrs ----

Could not compile a test program checking for lrs library.
The most probable reasons are that the library is installed at a non-standard location,
is not configured to build a shared module, or missing at all.
The complete error log follows:

ld: library not found for -llrs
clang: error: linker command failed with exit code 1 (use -v to see invocation)

Please install the library and specify its location using --with-lrs option, if needed.
Please remember to enable shared modules when configuring the lrs library!

As Benjamin pointed out, the error message does not match the one expected by bundled/lrs/support/configure.pl script, which tries to be too helpful.

@mkoeppe mkoeppe changed the title Fix polymake 3.4's lrslib detection Fix polymake 3.4's lrslib detection, add dependency on ppl May 9, 2019
@dimpase
Copy link
Member

dimpase commented May 10, 2019

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented May 10, 2019

comment:9

tests fine.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 8, 2019

comment:11

This branch has been merged already as part of #22704.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants