Create a variant of the polymake interface using polymake's callable library (polymake::Main) via JuPyMake #22704

mkoeppe · 2017-03-28T23:10:45Z

Following up on #22452 (Create a Polymake pexpect interface):

As suggested by Gawrilow in https://forum.polymake.org/viewtopic.php?f=8&t=544, we could create a variant of the polymake pexpect interface that does not go through pty's but rather replaces the relevant send/receive methods of pexpect by calls to simulate_shell_input (linking to libpolymake).

Recent polymake versions have developed this further and now provide a class polymake::Main with convenient access to the polymake interpreter. We use the (partial) Python bindings for this, https://github.com/polymake/JuPyMake which are used for Polymake's jupyter.

Upstream package:

  wget -P upstream https://files.pythonhosted.org/packages/32/dd/0a48546daa2461e57207d31eeb64a3ad77fd9fb339d90e1e067ea25991a5/JuPyMake-0.9.tar.gz

We do want to keep the current pty-based pexpect interface, though, because it may be handy for running polymake on a remote server; or for guarding against a crashing polymake (sigh).

Remaining issue: #27807

See also: #22710: Meta-ticket: polymake

Depends on #24905

Upstream: Reported upstream. No feedback yet.

CC: @simon-king-jena @jplab @sophiasage @LaisRast @kliem @sebasguts @videlec @tscrim

Component: interfaces

Keywords: days84

Author: Matthias Koeppe

Branch: 8d9e2c2

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/22704

The text was updated successfully, but these errors were encountered:

mkoeppe · 2017-03-30T20:53:18Z

Dependencies: #22452

mkoeppe · 2018-09-21T20:23:08Z

Changed dependencies from #22452 to #22452, #26333

mkoeppe · 2019-04-27T09:32:24Z

Branch: public/22704

mkoeppe · 2019-04-27T09:37:59Z

comment:5

Here's a first version.

Last 10 new commits:

`7018013`	`polymake doctest: Mark a doctest random that depends on installed packages`
`78c10fb`	`Polymake._tab_completion: Fix for new apropos format in Polymake 3.4`
`1699019`	`Doctest fix for polymake 3.4: false/true instead of 0/1`
`f595909`	`Doctest fix for polymake 3.4: Use different function from the tropical application`
`76701f6`	`Doctest fix for polymake 3.4: Differences in available properties`
`83b51de`	`Polymake 3.4: Fix for typeof small objects`
`8510124`	`Polymake: Remove copy/paste error handling for code that cannot raise`
`3c6ae95`	`polymake: Make normaliz a dependency`
`b6eeaa1`	`polymake: Add a patch to polymake's libnormaliz configure`
`2f855b0`	`Refactor interface Polymake through PolymakeAbstract, add PolymakeJuPyMake`

mkoeppe · 2019-04-27T09:37:59Z

Commit: 2f855b0

sagetrac-git · 2019-04-27T11:19:09Z

Branch pushed to git repo; I updated commit sha1. New commits:

`78b5036`	`More doctests etc.`

sagetrac-git · 2019-04-27T11:19:09Z

Changed commit from 2f855b0 to 78b5036

sagetrac-git · 2019-04-27T13:24:57Z

Changed commit from 78b5036 to 92274e0

sagetrac-git · 2019-04-27T13:24:57Z

Branch pushed to git repo; I updated commit sha1. New commits:

`92274e0`	`Add package jupymake`

mkoeppe · 2019-04-27T13:40:43Z

comment:10

Some polymake errors are not properly signalled by Polymake: Only the stderr slot [2] is filled but the error slot [3] is empty

sage: from JuPyMake import ExecuteCommand
sage: ExecuteCommand('help("Triangulation");')
(True, '', "polymake:  ERROR: unknown help topic 'Triangulation'\n", '')

sagetrac-git · 2019-04-27T14:54:07Z

Branch pushed to git repo; I updated commit sha1. New commits:

`b40a1cb`	`No need for File::Slurp in jupymake interface`
`6bd4971`	`Add doc`

sagetrac-git · 2019-04-27T14:54:07Z

Changed commit from 92274e0 to 6bd4971

sagetrac-git · 2019-04-27T15:25:28Z

Branch pushed to git repo; I updated commit sha1. New commits:

`0bad10c`	`Fix jupymake help`

sagetrac-git · 2019-04-27T15:25:28Z

Changed commit from 6bd4971 to 0bad10c

sagetrac-git · 2019-04-27T16:08:23Z

Changed commit from 0bad10c to 6708663

sagetrac-git · 2019-04-27T16:08:23Z

Branch pushed to git repo; I updated commit sha1. New commits:

`624ac01`	`polymake: Also provide core functions`
`6708663`	`Merge branch 't/24905/public/upgrade_polymake_to_version_3_2r4' into t/22704/public/22704`

sagetrac-git · 2019-04-27T17:42:51Z

Branch pushed to git repo; I updated commit sha1. New commits:

`a5c8eb8`	`Add optional - polymake`
`ad2b976`	`Can only quit polymake in pexpect interface`
`7ec6c74`	`Mark jupymake tests optional - jupymake`
`8b7ffbd`	`Select polymake interface based on feature test`
`a614876`	`Fixup polymake doctests that depend on 'used package' messages`

sagetrac-git · 2019-04-27T17:42:51Z

Changed commit from 6708663 to a614876

mkoeppe · 2019-05-09T13:02:30Z

comment:46

The lrslib 070 update (#27745) is too much work for today. Instead I configure lrslib with LRS_QUIET (#27805).

dimpase · 2019-05-09T15:06:55Z

Changed dependencies from #24905, #27803, #27805 to #24905

dimpase · 2019-05-09T15:06:55Z

comment:47

OK, this is fixed by #27805 indeed.

New commits:

`2eda6e1`	`polymake: add to fedora instructions`
`5916141`	`Fix polymake lrslib detection`
`086bb2d`	`Merge branch 't/27803/public/27803-polymake-lrslib-detection' into t/22704/public/22704`
`1b47911`	`Configure lrslib with LRS_QUIET`
`c84d89d`	`Merge branch 't/27805/configure_lrslib_with_lrs_quiet' into t/22704/public/22704`

dimpase · 2019-05-09T15:06:55Z

Reviewer: Dima Pasechnik

mkoeppe · 2019-05-09T16:03:47Z

comment:48

I've put the remaining minor issue to a follow-up ticket, #27807 (Polymake-jupymake interface: Fix polymake's error handling in Shell::Mock)

mkoeppe · 2019-05-09T16:12:43Z

comment:49

Should I make that last failing doctest less specific regarding the error message for this ticket? (Before it's fixed fully in #27807)

dimpase · 2019-05-09T16:14:30Z

comment:50

If you like, you can tag it "known error".

sagetrac-git · 2019-05-09T16:20:22Z

Changed commit from c84d89d to 58aa1ad

sagetrac-git · 2019-05-09T16:20:22Z

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

`58aa1ad`	`Mark issue of #27807 as known bug`

vbraun · 2019-05-11T13:40:52Z

comment:53

Merge conflict

sagetrac-git · 2019-05-11T15:02:35Z

Changed commit from 58aa1ad to 8d9e2c2

sagetrac-git · 2019-05-11T15:02:35Z

Branch pushed to git repo; I updated commit sha1. New commits:

`8d9e2c2`	`Merge tag '8.8.beta5' into t/22704/public/22704`

vbraun · 2019-05-14T12:37:24Z

Changed branch from public/22704 to 8d9e2c2

mkoeppe · 2019-07-21T20:33:19Z

comment:57

The upstream package jupymake seems to be missing on the sage mirrors

mkoeppe · 2019-07-21T20:33:19Z

Changed commit from 8d9e2c2 to none

jplab · 2019-07-28T11:40:09Z

comment:58

Do I understand correctly that in the current version jupymake is necessary for polymake to function properly? Shouldn't jupymake become a dependancy of polymake?

mkoeppe · 2019-07-29T23:13:05Z

comment:59

Replying to @jplab:

Do I understand correctly that in the current version jupymake is necessary for polymake to function properly? Shouldn't jupymake become a dependancy of polymake?

No, there are two interface classes, which both work. PolymakeExpect (aliases to Polymake) and PolymakeJupyMake.
Depending on whether you have jupymake, polymake is set to an instance of one or the other.

mkoeppe added this to the sage-8.0 milestone Mar 28, 2017

mkoeppe added c: interfaces labels Mar 28, 2017

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~Create a variant of the polymake pexpect interface using polymake's simulate_shell_input~~ Create a variant of the polymake pexpect interface using polymake's simulate_shell_input / JuPyMake Sep 21, 2018

mkoeppe modified the milestones: sage-8.0, sage-8.4 Sep 21, 2018

This comment has been minimized.

Sign in to view

dimpase added s: positive review and removed s: needs review labels May 9, 2019

This comment has been minimized.

Sign in to view

sagetrac-git mannequin added s: needs review and removed s: positive review labels May 9, 2019

mkoeppe added s: positive review and removed s: needs review labels May 10, 2019

vbraun added s: needs work and removed s: positive review labels May 11, 2019

mkoeppe added s: positive review and removed s: needs work labels May 11, 2019

vbraun removed the s: positive review label May 14, 2019

vbraun closed this as completed in 473a81b May 14, 2019

Create a variant of the polymake interface using polymake's callable library (polymake::Main) via JuPyMake #22704

Create a variant of the polymake interface using polymake's callable library (polymake::Main) via JuPyMake #22704

Comments

mkoeppe commented Mar 28, 2017

mkoeppe commented Mar 30, 2017

This comment has been minimized.

This comment has been minimized.

mkoeppe commented Sep 21, 2018

mkoeppe commented Apr 27, 2019

mkoeppe commented Apr 27, 2019

This comment has been minimized.

mkoeppe commented Apr 27, 2019

sagetrac-git mannequin commented Apr 27, 2019

sagetrac-git mannequin commented Apr 27, 2019

This comment has been minimized.

This comment has been minimized.

sagetrac-git mannequin commented Apr 27, 2019

sagetrac-git mannequin commented Apr 27, 2019

mkoeppe commented Apr 27, 2019

sagetrac-git mannequin commented Apr 27, 2019

sagetrac-git mannequin commented Apr 27, 2019

sagetrac-git mannequin commented Apr 27, 2019

sagetrac-git mannequin commented Apr 27, 2019

sagetrac-git mannequin commented Apr 27, 2019

sagetrac-git mannequin commented Apr 27, 2019

sagetrac-git mannequin commented Apr 27, 2019

sagetrac-git mannequin commented Apr 27, 2019

mkoeppe commented May 9, 2019

dimpase commented May 9, 2019

dimpase commented May 9, 2019

dimpase commented May 9, 2019

mkoeppe commented May 9, 2019

This comment has been minimized.

mkoeppe commented May 9, 2019

dimpase commented May 9, 2019

sagetrac-git mannequin commented May 9, 2019

sagetrac-git mannequin commented May 9, 2019

vbraun commented May 11, 2019

sagetrac-git mannequin commented May 11, 2019

sagetrac-git mannequin commented May 11, 2019

vbraun commented May 14, 2019

mkoeppe commented Jul 21, 2019

mkoeppe commented Jul 21, 2019

jplab commented Jul 28, 2019

mkoeppe commented Jul 29, 2019