Skip to content

Polymake-jupymake interface: Fix polymake's error handling in Shell::Mock #27807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mkoeppe opened this issue May 9, 2019 · 9 comments
Closed

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented May 9, 2019

This is a follow-up on #22704.

A patch suggested by Benjamin Lorenz fixes the following errors in error handling.

In [1]: import JuPyMake
In [2]: JuPyMake.InitializePolymake()
Out[2]: True
In [4]: JuPyMake.ExecuteCommand('application("xyzzy");')
Out[4]:
(True,
 '',
 '',
 'Can\'t locate object method "compile_scope" via package
"Polymake::Core::Shell::Mock" at
/Users/mkoeppe/s/sage/sage-rebasing/local/share/polymake/perllib/Polymake/utils.pl
line 247.\n')
In [6]: JuPyMake.ExecuteCommand('save(17);')
Out[6]:
(True,
 '',
 '',
 'Can\'t locate object method "compile_scope" via package
"Polymake::Core::Shell::Mock" at
/Users/mkoeppe/s/sage/sage-rebasing/local/share/polymake/perllib/Polymake/utils.pl
line 247.\n')

Depends on #22704

CC: @dimpase [email protected]

Component: interfaces: optional

Author: Matthias Koeppe

Branch/Commit: 799e6a4

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/27807

@mkoeppe mkoeppe added this to the sage-8.8 milestone May 9, 2019
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 10, 2019

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 10, 2019

Commit: 799e6a4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 10, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

799e6a4polymake doctest: Remove 'known bug' annotation

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 10, 2019

Dependencies: #22704

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 10, 2019

Author: Matthias Koeppe

@dimpase
Copy link
Member

dimpase commented May 10, 2019

comment:4

OK, good, seems to be fixed.

@dimpase
Copy link
Member

dimpase commented May 10, 2019

Reviewer: Dima Pasechnik

@vbraun
Copy link
Member

vbraun commented May 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants