Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 internet doctests failing in bibd.py #30131

Closed
seblabbe opened this issue Jul 13, 2020 · 13 comments
Closed

2 internet doctests failing in bibd.py #30131

seblabbe opened this issue Jul 13, 2020 · 13 comments

Comments

@seblabbe
Copy link
Contributor

With 9.2.beta4,

sage -t --optional=sage,internet src/sage/combinat/designs/bibd.py

gives

sage -t --long src/sage/combinat/designs/bibd.py
**********************************************************************
File "src/sage/combinat/designs/bibd.py", line 109, in sage.combinat.designs.bibd.balanced_incomplete_block_design
Failed example:
    B                                                              # optional - internet
Expected:
    Incidence structure with 66 points and 143 blocks
Got:
    (66,6,1)-Balanced Incomplete Block Design
**********************************************************************
File "src/sage/combinat/designs/bibd.py", line 113, in sage.combinat.designs.bibd.balanced_incomplete_block_design
Failed example:
    designs.balanced_incomplete_block_design(66, 6, 1, use_LJCR=True)  # optional - internet
Expected:
    Incidence structure with 66 points and 143 blocks
Got:
    (66,6,1)-Balanced Incomplete Block Design
**********************************************************************
1 item had failures:
   2 of  26 in sage.combinat.designs.bibd.balanced_incomplete_block_design
    0 tests not run because we ran out of time
    [120 tests, 2 failures, 5.32 s]

Component: doctest coverage

Author: Frédéric Chapoton

Branch/Commit: 8cf4741

Reviewer: Sébastien Labbé, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30131

@seblabbe seblabbe added this to the sage-9.2 milestone Jul 13, 2020
@seblabbe

This comment has been minimized.

@fchapoton
Copy link
Contributor

comment:2

done


New commits:

8cf4741fix optional internet doctests in bibd

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor

Commit: 8cf4741

@fchapoton
Copy link
Contributor

Branch: u/chapoton/30131

@seblabbe
Copy link
Contributor Author

comment:3

Doctests fixed. html doc builds okay.

@seblabbe
Copy link
Contributor Author

Reviewer: Sébastien Labbé

@Ivo-Maffei
Copy link
Mannequin

Ivo-Maffei mannequin commented Jul 15, 2020

comment:4

I think this ticket is a duplicate of #30107.
I merged this in that ticket as there was a merge conflict.

@dimpase
Copy link
Member

dimpase commented Jul 15, 2020

comment:5

should this be moved to duplicate/invalid Milestone then?

@seblabbe
Copy link
Contributor Author

comment:6

no, since #30107 is now based on #30131.

@dimpase
Copy link
Member

dimpase commented Jul 17, 2020

Changed reviewer from Sébastien Labbé to Sébastien Labbé, Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jul 17, 2020

comment:7

OK, thanks.

@vbraun
Copy link
Member

vbraun commented Jul 25, 2020

Changed branch from u/chapoton/30131 to 8cf4741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants