Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy build broken with SAGE_FAT_BINARY=yes #31521

Closed
mkoeppe opened this issue Mar 19, 2021 · 11 comments
Closed

numpy build broken with SAGE_FAT_BINARY=yes #31521

mkoeppe opened this issue Mar 19, 2021 · 11 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 19, 2021

Follow up from #29537.

Depends on #29537

CC: @embray @kliem @dimpase @vbraun

Component: packages: standard

Author: Jonathan Kliem

Branch/Commit: 128e8ef

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/31521

@mkoeppe mkoeppe added this to the sage-9.3 milestone Mar 19, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 24, 2021

comment:1

On macOS, with SAGE_FAT_BINARY=yes, I just got:

    [numpy-1.19.5]   Running from numpy source directory.
    [numpy-1.19.5]   Cythonizing sources
    [numpy-1.19.5]   usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
    [numpy-1.19.5]      or: setup.py --help [cmd1 cmd2 ...]
    [numpy-1.19.5]      or: setup.py --help-commands
    [numpy-1.19.5]      or: setup.py cmd --help
    [numpy-1.19.5]
    [numpy-1.19.5]   error: option --cpu-dispatch not recognized
    [numpy-1.19.5]   ********************************************************************************
    [numpy-1.19.5]   Error building a wheel for numpy-1.19.5

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 24, 2021

comment:3

Indeed, --cpu-dispatch has only been introduced in the 1.20.x series. We are still at 1.19.5.

Wondering how this has possibly passed in previous tests?!

@mkoeppe mkoeppe changed the title cygwin: numpy not portable despite using SAGE_FAT_BINARY=yes numpy build broken with SAGE_FAT_BINARY=yes Mar 24, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 24, 2021

comment:4

And I guess the prefix SAGE_ can be removed in the variable names in sage_conf...

@kliem
Copy link
Contributor

kliem commented Mar 24, 2021

comment:5

Reverting for now until numpy is updated.


New commits:

128e8efRevert "do not allow numpy intrinsics when building fat binary"

@kliem
Copy link
Contributor

kliem commented Mar 24, 2021

Author: Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Mar 24, 2021

Commit: 128e8ef

@kliem
Copy link
Contributor

kliem commented Mar 24, 2021

Branch: public/31521

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 24, 2021

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 24, 2021

comment:6

Thanks!

But we'll need another ticket then to actually fix the nonportability of the build...

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 26, 2021

comment:7

Replying to @mkoeppe:

But we'll need another ticket then to actually fix the nonportability of the build...

That's now #31565.

@vbraun
Copy link
Member

vbraun commented Mar 28, 2021

Changed branch from public/31521 to 128e8ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants