Build still non-portable despite SAGE_FAT_BINARY=yes because of numpy

[mkoeppe]

Follow-up from #29537, #31521.

Observed on cygwin-standard but likely also affects the Docker images and the Sage binary distribution.

With the upgrade to numpy 1.20.x (#31008), the non-portability shows as an error message instead of a crash:

  [sagelib-9.4.beta0]       from numpy.core._multiarray_umath import (
  [sagelib-9.4.beta0]   RuntimeError: NumPy was built with baseline optimizations: 
  [sagelib-9.4.beta0]   (SSE SSE2 SSE3 SSSE3 SSE41 POPCNT SSE42 AVX F16C FMA3 AVX2 AVX512F AVX512CD AVX512_SKX) but your machine doesn't support:
  [sagelib-9.4.beta0]   (AVX512F).
  [sagelib-9.4.beta0]   ************************************************************************
  [sagelib-9.4.beta0]   Error building the Sage library
  [sagelib-9.4.beta0]   ************************************************************************
  [sagelib-9.4.beta0] Full log file: /cygdrive/d/a/sage/sage/logs/pkgs/sagelib-9.4.beta0.log

Report withs the 9.3 Linux binary:

• https://groups.google.com/g/sage-devel/c/Lj-wx4xm0N4/m/9IiDtu4_CgAJ
• https://groups.google.com/g/sage-support/c/KZFZBoI6xJk/m/aBY9ZIxoBwAJ

Depends on #32257

CC: @embray @kliem @dimpase @vbraun @kiwifb @slel

Component: build

Keywords: sdl

Author: Jonathan Kliem

Branch/Commit: 49e531d

Reviewer: Thierry Monteil

Issue created by migration from https://trac.sagemath.org/ticket/31565

[kiwifb]

comment:2

What are the symptoms? I don't really do cygwin but I may do docker one day.

[mkoeppe]

comment:3

The symptom is that something you build on one machine does not run on another machine, aborting with SIGILL.

[mkoeppe]

comment:5

Moving to 9.4, as 9.3 has been released.

[mkoeppe]

Dependencies: #31008

[kliem]

comment:7

I guess we need to unwind #31521 now??

[mkoeppe]

comment:8

Ah, that's right!

[mkoeppe]

Branch: u/mkoeppe/build_still_non_portable_despite_sage_fat_binary_yes_because_of_numpy

[mkoeppe]

New commits:

b249c47

Revert "Revert "do not allow numpy intrinsics when building fat binary""

[mkoeppe]

Author: Jonathan Kliem

[mkoeppe]

Commit: b249c47

[mkoeppe]

Reviewer: https://github.com/mkoeppe/sage/actions/runs/952966309

[kliem]

comment:14

Thanks for taking care of this.

[mkoeppe]

comment:15

The cygwin-standard build looked rather promising (no "baseline optimizations" message, no crash when just importing numpy) but I am getting crashes again https://github.com/mkoeppe/sage/runs/2867645468 when the doctests do any plotting.

[mkoeppe]

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/952966309 to Matthias Koeppe

[mkoeppe]

comment:16

The other runs at https://github.com/mkoeppe/sage/runs/2865933225?check_suite_focus=true look clean.

So I consider this ticket already an improvement. We'll have to chase the crash on cygwin when switching CPUs between build stages in ... yet another ... follow-up ticket.

[kliem]

comment:25

https://github.com/kliem/sage/pull/46/checks

[mkoeppe]

comment:26

Unclear whether this is still needed now that #32021 is merged in 9.4.beta5

[mkoeppe]

Changed dependencies from #31008 to #32257

[mkoeppe]

comment:28

With #32021 and the pynac build failure fixed by #32257, we are back to being able to build and run the testsuite on Cygwin. https://github.com/mkoeppe/sage/runs/3126612760?check_suite_focus=true

Numerous SIGSEGVs whenever plotting is involved point to more trouble with numpy.

I'll try out the branch of the present ticket on top of #32257.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d4156f7	build/pkgs/singular/patches/0001-factory-canonicalform.h-Add-more-FACTORY_PUBLIC.patch: New
49e531d	disable baseline in case of SAGE_FAT_BINARY

[sagetrac-git]

Changed commit from 82ae485 to 49e531d

[mkoeppe]

Changed reviewer from Matthias Koeppe to https://github.com/mkoeppe/sage/actions/runs/1054288431

[mkoeppe]

comment:30

That's now running at https://github.com/mkoeppe/sage/actions/runs/1054288431

[mkoeppe]

comment:31

Replying to @mkoeppe:

Numerous SIGSEGVs whenever plotting is involved point to more trouble with numpy.

I'll try out the branch of the present ticket on top of #32257.

Same issues as before.

[mkoeppe]

comment:32

Testing with #32080 merged at https://github.com/mkoeppe/sage/actions/runs/1056686451

[mkoeppe]

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1054288431 to none

[mkoeppe]

comment:33

Also with #32080 no change. Segfaults on every plot.

Next step would be to try to reproduce this in a local installation in Cygwin.

[mkoeppe]

comment:35

Reduced to critical - see https://groups.google.com/g/sage-release/c/91CGN0cra2k/m/1WwPZNshBQAJ

[sagetrac-tmonteil]

Changed keywords from none to sdl

[sagetrac-tmonteil]

Reviewer: Thierry Monteil

[sagetrac-tmonteil]

comment:36

I confirm that this branch fixes SSE2 bug for numpy in a quemulated Pentium 3. Note however that the error appeared at run time not build time.

As this will allow me to rebuild 32bit patchbots and a new SDL for bullseye release (which i did not do for a while), i am +1 for setting this ticket a blocker and get it merged in 9.4.

[sagetrac-tmonteil]

comment:37

If nobody complains.

[vbraun]

Changed branch from public/31565 to 49e531d