Remove or tag uses of SR and symbolic functions in combinat, categories, etc. #32609

mkoeppe · 2021-10-02T16:53:58Z

Follow-up on #32411.

Use of floor/ceil from sage.functions can be avoided.

Modules that only need symbolics in some methods should avoid module-level imports from sage.functions, sage.symbolic, sage.calculus.

Doctests that need these modules should be marked # optional - sage.symbolic.

This can be tested using #32601 (sagemath-standard-no-symbolics)

CC: @tscrim

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: 4a1b489

Reviewer: Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/32609

The text was updated successfully, but these errors were encountered:

mkoeppe · 2022-02-27T22:58:22Z

Branch: u/mkoeppe/remove_more_unnecessary_uses_of_sr_and_symbolic_functions_in_sage_combinat

mkoeppe · 2022-02-27T23:02:15Z

Commit: 04855a1

mkoeppe · 2022-02-27T23:02:15Z

New commits:

`6bd6903`	`PowerSeriesRing_generic._element_constructor_: Only import sage.symbolic.expression.SymbolicSeries after isinstance test with ABC Expression`
`9730b10`	`src/sage/categories/metric_spaces.py: Mark doctests using HyperbolicPlane # optional - sage.symbolic`
`dca7113`	`In doctests, replace floor(.../...) by //`
`44ac5ab`	`src/sage/categories/vector_bundles.py: Mark doctests # optional - sage.symbolic`
`71303dd`	`src/sage/matrix/operation_table.py: Use math.log, log10 insteadd of importing from sage.misc.functional`
`04855a1`	`src/sage/groups/matrix_gps/coxeter_group.py: Do not use sage.symbolic for easy cases of cos(pi/x)`

mkoeppe · 2022-02-27T23:02:45Z

Author: Matthias Koeppe

sagetrac-git · 2022-02-27T23:13:05Z

Changed commit from 04855a1 to ecad015

sagetrac-git · 2022-02-27T23:13:05Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ecad015`	`src/sage/groups/matrix_gps/coxeter_group.py: Do not use sage.symbolic for easy cases of cos(pi/x) (fixup)`

sagetrac-git · 2022-02-28T00:45:40Z

Changed commit from ecad015 to 2511e3e

sagetrac-git · 2022-02-28T00:45:40Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`5d2cc6b`	`PowerSeriesRing_generic._element_constructor_: Only import sage.symbolic.expression.SymbolicSeries after isinstance test with ABC Expression`
`dc8cc8c`	`src/sage/categories/metric_spaces.py: Mark doctests using HyperbolicPlane # optional - sage.symbolic`
`9ca27e7`	`In doctests, replace floor(.../...) by //`
`444b659`	`src/sage/categories/vector_bundles.py: Mark doctests # optional - sage.symbolic`
`63b0ad8`	`src/sage/matrix/operation_table.py: Use math.log, log10 insteadd of importing from sage.misc.functional`
`13c5092`	`src/sage/groups/matrix_gps/coxeter_group.py: Do not use sage.symbolic for easy cases of cos(pi/x)`
`2511e3e`	`src/sage/groups/matrix_gps/coxeter_group.py: Do not use sage.symbolic for easy cases of cos(pi/x) (fixup)`

sagetrac-git · 2022-02-28T01:06:54Z

Changed commit from 2511e3e to ea8d379

sagetrac-git · 2022-02-28T01:06:54Z

Branch pushed to git repo; I updated commit sha1. New commits:

`e3b36fa`	`src/sage/categories/algebra_functor.py: Make doctests using sqrt # optional - sage.symbolic`
`ea8d379`	`src/sage/categories/rings.py: Mark doctests using sqrt # optional - sage.symbolic`

sagetrac-git · 2022-02-28T01:31:26Z

Changed commit from ea8d379 to 9cae6cb

sagetrac-git · 2022-02-28T01:31:26Z

Branch pushed to git repo; I updated commit sha1. New commits:

`c7bd9ad`	`src/sage/arith/multi_modular.pyx: Use primecountpy.primecount directly instead of going through sage.functions`
`9cae6cb`	`src/sage/groups/semimonomial_transformations/semimonomial_transformation_group.py: Import factorial from sage.arith.misc`

sagetrac-git · 2022-02-28T02:24:48Z

Branch pushed to git repo; I updated commit sha1. New commits:

`994f47b`	`src/sage/categories/number_fields.py: Remove abuse of predefined x in doctests`
`4a1fc16`	`src/sage/structure/element.pyx: Remove abuse of predefined x in doctests`
`c6714aa`	`src/sage/categories/coxeter_groups.py: Mark a doctest # optional - sage.symbolic`
`30fa675`	`src/sage/categories/pushout.py: Remove abuse of predefined x in doctests`
`3cd7195`	`src/sage/categories/modules_with_basis.py: In doctest, import factorial from sage.arith.misc`

sagetrac-git · 2022-02-28T02:24:48Z

Changed commit from 9cae6cb to 3cd7195

sagetrac-git · 2022-02-28T03:06:29Z

Branch pushed to git repo; I updated commit sha1. New commits:

`2445b36`	`src/sage/categories/chain_complexes.py: Mark doctests using manifolds # optional - sage.symbolic`

sagetrac-git · 2022-02-28T03:06:29Z

Changed commit from 3cd7195 to 2445b36

sagetrac-git · 2022-02-28T03:12:57Z

Branch pushed to git repo; I updated commit sha1. New commits:

`fe0c388`	`src/sage/categories/lie_algebras.py: Mark doctests using manifolds # optional - sage.symbolic`

sagetrac-git · 2022-02-28T03:12:57Z

Changed commit from 2445b36 to fe0c388

sagetrac-git · 2022-02-28T03:15:58Z

Changed commit from fe0c388 to e197558

sagetrac-git · 2022-02-28T03:15:58Z

Branch pushed to git repo; I updated commit sha1. New commits:

`e197558`	`src/sage/categories/finite_dimensional_nilpotent_lie_algebras_with_basis.py: Mark doctests using manifolds # optional - sage.symbolic`

sagetrac-git · 2022-02-28T03:19:34Z

Branch pushed to git repo; I updated commit sha1. New commits:

`3ede66a`	`src/sage/categories/finite_permutation_groups.py: Mark a doctest # optional - sage.symbolic`
`caf233e`	`src/sage/categories/metric_spaces.py: Mark a doctest # optional - sage.symbolic`

mkoeppe · 2022-02-28T22:20:28Z

comment:18

Replying to @slel:

Some more parts can be made symbolics-free,
though sometimes it makes things convoluted.

File src/sage/categories/algebra_functor.py

We can bypass using sqrt(5) to construct ZZ[sqrt(5)]:
    sage: G = GL(2, 7)
    sage: K = QuadraticField(5, 'srqt5')
    sage: Zr5 = K.order(K.gen())  # This is ZZ[sqrt(5)]

Or just ZZ[AA(5).sqrt()]

sagetrac-git · 2022-02-28T22:23:57Z

Changed commit from e177b45 to bbe19ad

sagetrac-git · 2022-02-28T22:23:57Z

Branch pushed to git repo; I updated commit sha1. New commits:

`bbe19ad`	`src/sage/categories/algebra_functor.py: In doctest, use ZZ[AA(5).sqrt()] instead of ZZ[sqrt(5)] to avoid symbolics`

sagetrac-git · 2022-02-28T22:27:12Z

Changed commit from bbe19ad to 5d82771

sagetrac-git · 2022-02-28T22:27:12Z

Branch pushed to git repo; I updated commit sha1. New commits:

`5d82771`	`src/sage/categories/coxeter_groups.py: In doctest, avoid using symbolics`

mkoeppe · 2022-02-28T22:27:39Z

comment:21

Replying to @slel:

File src/sage/categories/coxeter_groups.py

Using a polynomial variable can bypass symbolics here [...]

Thanks, I've made a similar change

sagetrac-git · 2022-02-28T22:37:20Z

Branch pushed to git repo; I updated commit sha1. New commits:

`3851908`	`src/sage/categories/pushout.py: In doctest, avoid using symbolics`

sagetrac-git · 2022-02-28T22:37:20Z

Changed commit from 5d82771 to 3851908

slel · 2022-02-28T23:19:56Z

comment:23

I like ZZ[AA(5).sqrt()] but it does not name
the generator sqrt5 as ZZ[sqrt(5)]:

sage: ZZ[sqrt(5)]
Order in Number Field in sqrt5 with defining polynomial x^2 - 5 with sqrt5 = 2.236067977499790?
sage: ZZ[AA(5).sqrt()]
Order in Number Field in a with defining polynomial x^2 - 5 with a = 2.236067977499790?

so you need to change:

     sage: OG(OG.base_ring().basis()[1])
-    sqrt5*[1 0]
+    a*[1 0]
     [0 1]

sagetrac-git · 2022-02-28T23:27:58Z

Branch pushed to git repo; I updated commit sha1. New commits:

`595f99a`	`src/sage/categories/algebra_functor.py: Update doctest output`

sagetrac-git · 2022-02-28T23:27:58Z

Changed commit from 3851908 to 595f99a

sagetrac-git · 2022-03-01T06:27:58Z

Changed commit from 595f99a to ed59c28

sagetrac-git · 2022-03-01T06:27:58Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ed59c28`	`src/sage/categories/pushout.py: Fix typo in doctest`

sagetrac-git · 2022-03-01T06:30:30Z

Branch pushed to git repo; I updated commit sha1. New commits:

`518bb96`	`src/sage/categories/modules_with_basis.py: Update doctest output`

sagetrac-git · 2022-03-01T06:30:30Z

Changed commit from ed59c28 to 518bb96

mkoeppe · 2022-03-01T18:30:50Z

comment:27

The remaining doctest failure (and the pyflakes warnings) seen in the patchbot run are not from this ticket.

mkoeppe · 2022-03-02T22:50:41Z

Reviewer: Samuel Lelièvre

sagetrac-git · 2022-03-08T17:46:30Z

Changed commit from 518bb96 to 4a1b489

sagetrac-git · 2022-03-08T17:46:30Z

Branch pushed to git repo; I updated commit sha1. New commits:

`4a1b489`	`Merge tag '9.6.beta4' into t/32609/remove_more_unnecessary_uses_of_sr_and_symbolic_functions_in_sage_combinat`

slel · 2022-03-09T11:26:00Z

comment:30

If bots go green or only report errors unrelated to this, positive review.

mkoeppe · 2022-03-09T22:15:14Z

comment:31

Patchbot failures and pyflakes warnings are unrelated.

mkoeppe · 2022-03-09T22:15:25Z

comment:32

Thank you!

vbraun · 2022-03-12T15:11:17Z

Changed branch from u/mkoeppe/remove_more_unnecessary_uses_of_sr_and_symbolic_functions_in_sage_combinat to 4a1b489

mkoeppe added this to the sage-9.5 milestone Oct 2, 2021

mkoeppe added t: refactoring labels Oct 2, 2021

mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~Remove more unnecessary uses of SR and symbolic functions in sage.combinat~~ Remove more unnecessary uses of SR and symbolic functions in sage.combinat, sage.categories etc. Feb 27, 2022

mkoeppe added the s: needs review label Feb 27, 2022

slel changed the title ~~Remove more unnecessary uses of SR and symbolic functions in sage.combinat, sage.categories etc.~~ Remove or tag uses of SR and symbolic functions in combinat, categories, etc. Feb 28, 2022

mkoeppe added s: positive review and removed s: needs review labels Mar 9, 2022

vbraun removed the s: positive review label Mar 12, 2022

vbraun closed this as completed in 045292b Mar 12, 2022

mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023

Merge sagemath#32609

0d1afea

mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 17, 2023

Merge sagemath#32609

6c8eeb9

Remove or tag uses of SR and symbolic functions in combinat, categories, etc. #32609

Remove or tag uses of SR and symbolic functions in combinat, categories, etc. #32609

Comments

mkoeppe commented Oct 2, 2021

mkoeppe commented Feb 27, 2022

mkoeppe commented Feb 27, 2022

mkoeppe commented Feb 27, 2022

This comment has been minimized.

mkoeppe commented Feb 27, 2022

sagetrac-git mannequin commented Feb 27, 2022

sagetrac-git mannequin commented Feb 27, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

mkoeppe commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

mkoeppe commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

slel commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Feb 28, 2022

sagetrac-git mannequin commented Mar 1, 2022

sagetrac-git mannequin commented Mar 1, 2022

sagetrac-git mannequin commented Mar 1, 2022

sagetrac-git mannequin commented Mar 1, 2022

mkoeppe commented Mar 1, 2022

mkoeppe commented Mar 2, 2022

sagetrac-git mannequin commented Mar 8, 2022

sagetrac-git mannequin commented Mar 8, 2022

slel commented Mar 9, 2022

mkoeppe commented Mar 9, 2022

mkoeppe commented Mar 9, 2022

vbraun commented Mar 12, 2022