sage.geometry: More # optional for test with examples that need sage.combinat, sage.rings.number_field, sage.plot

[mkoeppe]

cherry-picked from #32432.

We also fix up sage.features.sagemath.

CC: @kliem

Component: refactoring

Author: Matthias Koeppe

Branch: b846c0a

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32732

[mkoeppe]

Branch: u/mkoeppe/sage_geometry_polyhedron__more___optional_for_test_with_examples_that_need_sage_combinat_etc_

[mkoeppe]

Commit: 03ea96d

[mkoeppe]

Last 10 new commits:

7094aab	sage.geometry.polyedron.combinatorial_polyhedron: Mark more doctests # optional - sage.combinat
7ff2f74	src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx: Some more # optional
6baf055	src/sage/geometry/polyhedron/base.py: Some more # optional
7c73a01	src/sage/geometry/polyhedron/base.py: Some more # optional
5a3dbf4	src/sage/geometry/polyhedron/combinatorial_polyhedron/face_iterator.pyx: Mark doctests # optional - sage.rings.number_field or sage.combinat
e236b52	src/sage/geometry/polyhedron/combinatorial_polyhedron/base.pyx: More # optional
d892e34	git grep -l 'sage:.*plot' src/sage/geometry/ | xargs sed -i.bak '/sage: .*plot(/s/$/ # optional - sage.plot/'
2fd3fdf	src/sage/geometry/polyhedron/combinatorial_polyhedron/list_of_faces.pyx: Add '# optional - sage.combinat' for tests using combinatorial examples
59246d4	src/sage/geometry/polyhedron/representation.py: Add '# optional - sage.rings.number_field' in doctests
03ea96d	src/sage/geometry/polyhedron/backend_polymake.py: Add # optional - sage.rings.number_field

[mkoeppe]

Author: Matthias Koeppe

[sagetrac-git]

Changed commit from 03ea96d to c97428e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c97428e

src/sage/geometry/polyhedron/combinatorial_polyhedron/combinatorial_face.pyx: fix typo

[dimpase]

Reviewer: Dima Pasechnik

[dimpase]

comment:6

lgtm

[mkoeppe]

comment:7

Thanks!

[mkoeppe]

comment:8

Except the patchbot indicates some failures

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

d77eb85

sage.geometry: Add missing # optional tags

[sagetrac-git]

Changed commit from c97428e to d77eb85

[mkoeppe]

comment:10

But there's something else wrong:
The log indicates
Using --optional=argcomplete,build,ccache,debian,dochtml,pip,sage,sage.rings.real_double,sage_spkg
... lots of the components such as sage.plot are missing

[sagetrac-git]

Changed commit from d77eb85 to 7755df9

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

905ead9	sage.features.PythonModule: Record the exception message as part of the reason
7755df9	sage.doctest.control, sage.features.sagemath: If --verbose is used, log the feature test results and reasons

[sagetrac-git]

Changed commit from 7755df9 to f32b992

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f32b992

src/sage/features/sagemath.py (sage.combinat): Fix the name of the tested PythonModule

[mkoeppe]

comment:14

With the new diagnostic messages issued with sage -t --verbose, we see:

FeatureTestResult('sage.combinat.combination', False), reason: Failed to import `sage.combinat.combination`: cannot import name complex_mpfr
FeatureTestResult('sage.graphs.graph', False), reason: Failed to import `sage.graphs.graph`: cannot import name complex_mpfr
FeatureTestResult('sage.plot.plot', False), reason: Failed to import `sage.plot.plot`: cannot import name complex_mpfr
FeatureTestResult('sage.rings.number_field.number_field_element', False), reason: Failed to import `sage.rings.number_field.number_field_element`: cannot import name complex_mpfr
FeatureTestResult('sage.rings.real_double', True), reason: Successfully imported `sage.rings.real_double`.
FeatureTestResult('sage.symbolic.expression', False), reason: Failed to import `sage.symbolic.expression`: cannot import name complex_mpfr

So some cyclic import business is happening here

[mkoeppe]

comment:16

Fixing the imports, or alternatively running the sagemath feature tests after sage.all has been imported, will be done in a follow-up ticket.

Let's see what the patchbot says now.

[sagetrac-git]

Changed commit from f32b992 to 30eee2e

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

30eee2e

src/sage/geometry/hyperbolic_space/hyperbolic_geodesic.py: Add another missing # optional - sage.plot

[sagetrac-git]

Changed commit from 30eee2e to c1b1d93

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c1b1d93

src/sage/geometry/polyhedron/plot.py: Add more # optional - sage.plot

[sagetrac-git]

Changed commit from c1b1d93 to 98522e0

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

eb31b22	src/sage/geometry/voronoi_diagram.py: Add # optional - sage.rings.number_field
d1b3bca	src/sage/geometry/integral_points.pyx: Add # optional - sage.rings.number_field
98522e0	src/sage/numerical: Add # optional - sage.rings.number_field

[sagetrac-git]

Changed commit from 98522e0 to b846c0a

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b846c0a

src/sage/numerical/backends/interactivelp_backend.pyx: Add missing # optional

[dimpase]

comment:22

lgtm

[mkoeppe]

comment:23

Thanks!

[vbraun]

Changed branch from u/mkoeppe/sage_geometry_polyhedron__more___optional_for_test_with_examples_that_need_sage_combinat_etc_ to b846c0a

[antonio-rojas]

comment:25

Is there a ticket to fix the imports already? Lots of tests are being skipped in beta6 because of this.

[antonio-rojas]

Changed commit from b846c0a to none

[mkoeppe]

comment:26

Help is welcome on tickets

• Refactor to break cyclic import in complex numbers #30741 ... which attempts to fix the cyclic import issues
• doctests: Detect "safe" external features even if "--optional=external" is not used #32174/sage.doctest.control: Replace use of sage.misc.package.list_packages #30746 ... which will sidestep this issue by importing stuff later