Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.rings.infinity: Remove hard dependency on real_lazy and real_mpfi #32778

Closed
mkoeppe opened this issue Oct 26, 2021 · 11 comments
Closed

sage.rings.infinity: Remove hard dependency on real_lazy and real_mpfi #32778

mkoeppe opened this issue Oct 26, 2021 · 11 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 26, 2021

This is for sagemath-polyhedra (#32432).

CC: @dimpase

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: fb9faa6

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/32778
@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 26, 2021
@mkoeppe mkoeppe changed the title sage.rings.infinity: Remove hard dependency on real_lazy sage.rings.infinity: Remove hard dependency on real_lazy and real_mpfi Oct 26, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 26, 2021

Branch: u/mkoeppe/sage_rings_infinity__remove_hard_dependency_on_real_lazy

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 26, 2021

Commit: afe634c

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 26, 2021

New commits:

afe634csage.rings.infinity: Remove hard dependency on real_lazy and real_mpfi

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 28, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

fb9faa6src/sage/rings/infinity.py: Fix up: Only call .parent() on elements

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 28, 2021

Changed commit from afe634c to fb9faa6

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 7, 2021

comment:7

one green patchbot, one patchbot that was not feeling well

ready for review

@dimpase
Copy link
Member

dimpase commented Nov 14, 2021

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Nov 14, 2021

comment:9

lgtm

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 14, 2021

comment:10

Thank you!

@vbraun
Copy link
Member

vbraun commented Nov 15, 2021

Changed branch from u/mkoeppe/sage_rings_infinity__remove_hard_dependency_on_real_lazy to fb9faa6

@vbraun vbraun closed this as completed in 44a3535 Nov 15, 2021
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#32778
9555224
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#32778
09b8d8f
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#32778
beca87f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe