Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weil restriction of scalars #5569

Closed
malb opened this issue Mar 19, 2009 · 5 comments
Closed

weil restriction of scalars #5569

malb opened this issue Mar 19, 2009 · 5 comments

Comments

@malb
Copy link
Member

malb commented Mar 19, 2009

While cleaning up mq.MPolynomialSystem I moved its misnamed change_ring() function to a more proper place, i.e. weil_restriction() on ideals. Note, that these are defined on varieties but we don't have any variety objects and the function indeed works with ideal generators.

CC: @JohnCremona

Component: commutative algebra

Issue created by migration from https://trac.sagemath.org/ticket/5569

@malb malb added this to the sage-3.4.1 milestone Mar 19, 2009
@malb malb self-assigned this Mar 19, 2009
@williamstein
Copy link
Contributor

comment:1
15:43 < wstein> The patch looks good, except why not define the Weil restriction of scalars
15:43 < wstein> functor.
15:43 < wstein> You don't define it, but giving a complete valid mathematical definition only
15:43 < wstein> takes about 2-3 sentences.
15:43 < wstein> I can't see why not to do that.
15:43 < malb> okay
15:44 < wstein> Serge Lang first taught me about that construction using equations
15:44 < wstein> when I was having lunch with him once in grad school.
15:44 < wstein> Then I personally realized it is a functor and used that to prove that
15:44 < malb> I knew about this for a while but learned the proper name just now
15:44 < wstein> it is unique up to whatever...
15:44 < wstein> It was just an exercise for me, of course, since it is all well known.
15:45 < wstein> Also, could you add an example that involves an elliptic curve (affine patch 
                of one, at least)
15:45 < wstein> over a quadratic field?
15:45 < wstein> That would be cool.

@malb
Copy link
Member Author

malb commented Mar 20, 2009

Attachment: weil_restriction.patch.gz

@williamstein
Copy link
Contributor

comment:4

I give this a positive review. Great work on the docstring!

One comment. It is sad that we have to write code like this to do a coercion:

 l = [helper(str(f))  for f in self.gens()] 

As a challenge to Martin -- can you improve Sage so this decimal string conversion (which could be a killer show stopper if the ideal had huge elements) isn't needed, and instead one can use a homomorphism?

@malb
Copy link
Member Author

malb commented Mar 23, 2009

comment:5

Replying to @williamstein:

As a challenge to Martin -- can you improve Sage so this decimal string conversion (which
could be a killer show stopper if the ideal had huge elements) isn't needed, and instead one
can use a homomorphism?

This is now #5590

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 23, 2009

comment:6

Merged in Sage 3.4.1.alpha0.

Cheers,

Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants