-
-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement Mestre's algorithm for constructing genus 2 hyperelliptic curves #6341
Comments
This comment has been minimized.
This comment has been minimized.
Attachment: trac_6341-mestre-extcode.patch.gz |
comment:2
Attachment: trac_6341-mestre.patch.gz Here's a work in progress version. The extcode patch
The main devel patch integrates everything, or at least starts to. |
Attachment: trac_6341-mestre-without-conic.patch.gz |
comment:4
Attachment: trac_6341-mestre-extcode-without-qfsolve.patch.gz The files "-without..." are the same as ncalexan's files, but with the Conic class removed and put in a separate patch at ticket 727. They still need the Conic class, but it may be better to view this as a separate enhancement. |
comment:5
This will be revived as part of a student project in August 2011. |
Changed keywords from mestre algorithm genus 2 hyperelliptic curves to mestre algorithm genus 2 hyperelliptic curves sd35 |
Author: Florian Bouyer |
comment:6
Code was written by Florian Bouyer in September 2011, it works very nicely. Now it is a coding sprint at Sage Days 35 to put this in. |
Attachment: trac_6341_mestre_algorithm.patch.gz An implementation of Mestre Algorithm |
comment:8
apply trac_6341_mestre_algorithm.patch (this helps patchbot) |
This comment has been minimized.
This comment has been minimized.
comment:9
See also #12199, which will later fill in some special cases. |
comment:10
See also #12200, which will later fill in some special case |
minor changes to first patch |
comment:11
Attachment: trac_6341_mestre_algoritm_2.patch.gz I corrected some typos and wasted white spaces pointed out by Marco |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:13
I'm reviewing and writing a reviewer's patch. Looks very good, but some small changes are needed that are easier to do than to explain. |
Reviewer: Marco Streng |
Attachment: 6341-more-corrections.patch.gz Attachment: 6341-more-corrections.2.patch.gz |
Changed work issues from correct ticket number in error message, not 5534, but 14755 to complete references (title and journal with volume) |
This comment has been minimized.
This comment has been minimized.
comment:30
Attachment: 6341-more-corrections.3.patch.gz (testing now) |
Changed work issues from complete references (title and journal with volume) to none |
Changed reviewer from Lassina Dembele to Lassina Dembele, Fredrik Stromberg |
comment:31
for patchbot: |
This comment has been minimized.
This comment has been minimized.
comment:33
apply 6341-mestre-only.patch and trac_6341-mestre-only_cleanup.patch and 6341-more-corrections.3.patch |
comment:34
I combined the patches into one, for easier review. Apply only 6341.patch |
This comment has been minimized.
This comment has been minimized.
ascii version of what was uploaded earlier this week |
comment:35
Attachment: 6341.patch.gz apply only 6341.patch |
comment:36
This is working for me. I've verified several more non-CM examples in Magma. |
Changed reviewer from Lassina Dembele, Fredrik Stromberg to Lassina Dembele, Fredrik Stromberg, Aly Deines |
Merged: sage-5.13.beta0 |
*** this ticket is still using the old workflow, just apply patches and ignore the "branch" field ***
An implementation of Mestre's algorithm for reconstructing genus 2 hyperelliptic curves from their invariants.
This is limited to fields of characteristic not 2, 3, 5 and to curves with automorphism group generated by the hyperelliptic involution. Curve equations are not reduced, hence are unusably large over QQ, but see below.
That's it. Various other tickets deal with extensions:
Apply:
CC: @ncalexan @mstreng @jpflori @sagetrac-lassina @fredstro
Component: number theory
Keywords: mestre algorithm genus 2 hyperelliptic curves sd35 sd51
Author: Florian Bouyer, Marco Streng
Branch: u/fstromberg/ticket/6341
Reviewer: Lassina Dembele, Fredrik Stromberg, Aly Deines
Merged: sage-5.13.beta0
Issue created by migration from https://trac.sagemath.org/ticket/6341
The text was updated successfully, but these errors were encountered: