Meta-PR: Replace imports from sage.*.all for namespace packages

src/.relint.yml

@@ -49,6 +49,6 @@
     Hint: namespace package. Type import_statements("SOME_IDENTIFIER") to find a more specific import,
     Hint: or use 'sage --fiximports' to fix automatically in the source file.
   # Keep in sync with SAGE_ROOT/src/sage/misc/replace_dot_all.py
-  pattern: 'from\s+sage(|[.](arith|categories|combinat|ext|graphs(|[.]decompositions)|interfaces|libs|matrix|misc|numerical(|[.]backends)|rings|sets))[.]all\s+import'
-  filePattern: '.*[.](py|pyx|pxi)$'
-  error: false # Make this a warning instead of an error for now
+  pattern: 'from\s+sage(|[.](arith|categories|combinat|ext|graphs(|[.]decompositions)|interfaces|libs|matrix|misc|numerical(|[.]backends)|rings(|[.]finite_rings)|sets))[.]all\s+import'
+  # imports from .all are allowed in all.py; also allow in some modules that need sage.all
+  filePattern: '(.*/|)(?!(all|benchmark|dev_tools|parsing|sage_eval))[^/.]*[.](py|pyx|pxi)$'

src/sage/algebras/affine_nil_temperley_lieb.py

@@ -7,7 +7,7 @@
 #  Distributed under the terms of the GNU General Public License (GPL)
 #                  https://www.gnu.org/licenses/
 # ****************************************************************************
-from sage.categories.all import AlgebrasWithBasis
+from sage.categories.algebras_with_basis import AlgebrasWithBasis
 from sage.combinat.root_system.cartan_type import CartanType
 from sage.combinat.root_system.weyl_group import WeylGroup
 from sage.rings.ring import Ring

src/sage/algebras/cluster_algebra.py

@@ -354,7 +354,7 @@
 
 from copy import copy
 
-from sage.arith.all import binomial
+from sage.arith.misc import binomial
 from sage.categories.homset import Hom
 from sage.categories.morphism import SetMorphism
 from sage.categories.rings import Rings

src/sage/algebras/free_algebra.py

@@ -149,7 +149,7 @@
 
 from sage.structure.factory import UniqueFactory
 from sage.misc.cachefunc import cached_method
-from sage.all import PolynomialRing
+from sage.rings.polynomial.polynomial_ring_constructor import PolynomialRing
 from sage.rings.ring import Algebra
 from sage.categories.algebras_with_basis import AlgebrasWithBasis
 from sage.combinat.free_module import CombinatorialFreeModule
@@ -282,7 +282,7 @@ def create_key(self, base_ring, arg1=None, arg2=None,
             PolRing = PolynomialRing(base_ring, *args, **kwds)
             if degrees is None:
                 return (PolRing,)
-            from sage.all import TermOrder
+            from sage.rings.polynomial.term_order import TermOrder
             T = TermOrder(PolRing.term_order(), PolRing.ngens() + 1)
             varnames = list(PolRing.variable_names())
             newname = 'x'

src/sage/algebras/free_algebra_quotient.py

@@ -359,7 +359,7 @@ def hamilton_quatalg(R):
     """
     n = 3
     from sage.algebras.free_algebra import FreeAlgebra
-    from sage.matrix.all import MatrixSpace
+    from sage.matrix.matrix_space import MatrixSpace
     A = FreeAlgebra(R, n, 'i')
     F = A.monoid()
     i, j, k = F.gens()

src/sage/algebras/group_algebra.py

@@ -35,8 +35,8 @@
 #                  http://www.gnu.org/licenses/
 #*****************************************************************************
 
-from sage.rings.all import IntegerRing
-from sage.categories.all import Rings
+from sage.rings.integer_ring import IntegerRing
+from sage.categories.rings import Rings
 from sage.categories.magmas import Magmas
 from sage.categories.additive_magmas import AdditiveMagmas
 from sage.categories.sets_cat import Sets

src/sage/algebras/hecke_algebras/ariki_koike_algebra.py

@@ -540,7 +540,7 @@ def dimension(self):
                     sage: LT.dimension()
                     29160
                 """
-                from sage.arith.all import factorial
+                from sage.arith.misc import factorial
                 return self._r**self._n * factorial(self._n)
 
             def some_elements(self):

src/sage/algebras/iwahori_hecke_algebra.py

@@ -30,10 +30,12 @@
 from sage.structure.parent import Parent
 from sage.structure.unique_representation import UniqueRepresentation
 from sage.categories.realizations import Realizations, Category_realization_of_parent
-from sage.categories.all import AlgebrasWithBasis, FiniteDimensionalAlgebrasWithBasis, CoxeterGroups
+from sage.categories.algebras_with_basis import AlgebrasWithBasis
+from sage.categories.finite_dimensional_algebras_with_basis import FiniteDimensionalAlgebrasWithBasis
+from sage.categories.coxeter_groups import CoxeterGroups
 from sage.rings.integer_ring import ZZ
 from sage.rings.polynomial.laurent_polynomial_ring import LaurentPolynomialRing
-from sage.arith.all import is_square
+from sage.arith.misc import is_square
 from sage.combinat.root_system.coxeter_group import CoxeterGroup
 from sage.sets.family import Family
 from sage.combinat.free_module import CombinatorialFreeModule

src/sage/algebras/lie_algebras/bch.py

@@ -20,7 +20,7 @@
 from sage.arith.misc import bernoulli
 from sage.categories.lie_algebras import LieAlgebras
 from sage.combinat.integer_vector import IntegerListsLex
-from sage.arith.all import factorial
+from sage.arith.misc import factorial
 from sage.rings.rational_field import QQ
 from sage.structure.element import canonical_coercion
 

src/sage/algebras/lie_algebras/free_lie_algebra.py

@@ -265,7 +265,7 @@ def graded_dimension(self, k):
         """
         if k == 0:
             return 0
-        from sage.arith.all import moebius
+        from sage.arith.misc import moebius
         s = len(self.lie_algebra_generators())
         k = ZZ(k) # Make sure we have something that is in ZZ
         return sum(moebius(d) * s**(k // d) for d in k.divisors()) // k

src/sage/algebras/lie_conformal_algebras/lie_conformal_algebra_element.py

@@ -14,7 +14,7 @@
 # (at your option) any later version.
 #                  https://www.gnu.org/licenses/
 # ****************************************************************************
-from sage.arith.all import factorial
+from sage.arith.misc import factorial
 from sage.misc.misc_c import prod
 from sage.misc.repr import repr_lincomb
 from sage.misc.latex import latex

src/sage/algebras/lie_conformal_algebras/lie_conformal_algebra_with_structure_coefs.py

@@ -17,7 +17,7 @@
 #                  https://www.gnu.org/licenses/
 # ****************************************************************************
 
-from sage.arith.all import binomial
+from sage.arith.misc import binomial
 from sage.sets.family import Family
 from .lie_conformal_algebra_element import LCAStructureCoefficientsElement
 from sage.categories.lie_conformal_algebras import LieConformalAlgebras

src/sage/algebras/quatalg/quaternion_algebra.py

@@ -35,9 +35,14 @@
 #                  https://www.gnu.org/licenses/
 # ****************************************************************************
 
-from sage.arith.all import (hilbert_conductor_inverse, hilbert_conductor,
-                            factor, gcd, kronecker_symbol, valuation)
-from sage.rings.all import RR, Integer
+from sage.arith.misc import (hilbert_conductor_inverse,
+                             hilbert_conductor,
+                             factor,
+                             gcd,
+                             kronecker as kronecker_symbol,
+                             valuation)
+from sage.rings.real_mpfr import RR
+from sage.rings.integer import Integer
 from sage.rings.integer_ring import ZZ
 from sage.rings.rational import Rational
 from sage.rings.finite_rings.finite_field_constructor import GF

src/sage/algebras/schur_algebra.py

@@ -41,7 +41,7 @@
 from sage.combinat.sf.sf import SymmetricFunctions
 from sage.combinat.symmetric_group_algebra import SymmetricGroupAlgebra
 from sage.combinat.tableau import SemistandardTableaux
-from sage.arith.all import binomial
+from sage.arith.misc import binomial
 from sage.matrix.constructor import Matrix
 from sage.misc.cachefunc import cached_method
 from sage.misc.flatten import flatten

src/sage/algebras/shuffle_algebra.py

@@ -972,7 +972,7 @@ def expansion_on_basis(self, w):
             sage: S.expansion_on_basis(Word('abab'))
             2*B[aabb] + B[abab]
         """
-        from sage.arith.all import factorial
+        from sage.arith.misc import factorial
         if not w:
             return self._alg.one()
         if len(w) == 1:

src/sage/algebras/steenrod/steenrod_algebra.py

@@ -455,7 +455,9 @@
 from sage.combinat.free_module import CombinatorialFreeModule
 from sage.misc.lazy_attribute import lazy_attribute
 from sage.misc.cachefunc import cached_method
-from sage.categories.all import ModulesWithBasis, tensor, Hom
+from sage.categories.modules_with_basis import ModulesWithBasis
+from sage.categories.tensor import tensor
+from sage.categories.homset import Hom
 
 ######################################################
 # the main class
@@ -584,7 +586,7 @@ def __init__(self, p=2, basis='milnor', **kwds):
             sage: A1 == SteenrodAlgebra(2, profile=[2,1], basis='pst')
             False
         """
-        from sage.arith.all import is_prime
+        from sage.arith.misc import is_prime
         from sage.categories.super_hopf_algebras_with_basis import SuperHopfAlgebrasWithBasis
         from sage.categories.infinite_enumerated_sets import InfiniteEnumeratedSets
         from sage.categories.finite_enumerated_sets import FiniteEnumeratedSets

src/sage/algebras/steenrod/steenrod_algebra_mult.py

@@ -611,8 +611,9 @@ def multinomial_odd(list,p):
         sage: multinomial_odd([1,2,4], 107)
         105
     """
-    from sage.rings.all import GF, Integer
-    from sage.arith.all import binomial
+    from sage.rings.finite_rings.finite_field_constructor import FiniteField as GF
+    from sage.rings.integer import Integer
+    from sage.arith.misc import binomial
     n = sum(list)
     answer = 1
     F = GF(p)

src/sage/arith/multi_modular.pyx

@@ -16,7 +16,7 @@ from cysignals.memory cimport check_allocarray, check_reallocarray, sig_free
 
 from sage.libs.gmp.mpz cimport *
 from sage.rings.integer cimport Integer, smallInteger
-from sage.arith.all import random_prime
+from sage.arith.misc import random_prime
 from types import GeneratorType
 from sage.ext.stdsage cimport PY_NEW
 from cpython.object cimport PyObject_RichCompare

src/sage/arith/numerical_approx.pyx

@@ -15,7 +15,9 @@ Generic numerical approximation function
 from sage.structure.parent cimport Parent
 from sage.structure.element cimport parent
 cdef Parent CDF
-from sage.rings.all import RealField, ComplexField, CDF
+from sage.rings.real_mpfr import RealField
+from sage.rings.complex_mpfr import ComplexField
+from sage.rings.complex_double import CDF
 
 
 def numerical_approx_generic(x, prec):

src/sage/coding/bch_code.py

@@ -27,8 +27,8 @@
 from sage.modules.free_module_element import vector
 from sage.misc.misc_c import prod
 from sage.categories.fields import Fields
-from sage.arith.all import gcd
-from sage.rings.all import Zmod
+from sage.arith.misc import gcd
+from sage.rings.finite_rings.integer_mod_ring import IntegerModRing as Zmod
 
 from .cyclic_code import CyclicCode
 from .grs_code import GeneralizedReedSolomonCode

src/sage/coding/binary_code.pyx

@@ -4103,7 +4103,7 @@ cdef class BinaryCodeClassifier:
                     m = BinaryCode(matrix(ZZ, rs))
 
                     m_aut_gp_gens, m_labeling, m_size, m_base = self._aut_gp_and_can_label(m)
-                    from sage.arith.all import factorial
+                    from sage.arith.misc import factorial
                     if True:  # size*factorial(n-B.ncols) == m_size:
 
                         if len(m_aut_gp_gens) == 0:

src/sage/coding/code_bounds.py

@@ -173,11 +173,14 @@
 #                  https://www.gnu.org/licenses/
 # ****************************************************************************
 
+from sage.arith.misc import binomial, is_prime_power
 from sage.libs.gap.libgap import libgap
-from sage.rings.all import QQ, RR, ZZ, RDF
-from sage.arith.misc import is_prime_power
-from sage.arith.all import binomial
 from sage.misc.functional import sqrt, log
+from sage.rings.integer_ring import ZZ
+from sage.rings.rational_field import QQ
+from sage.rings.real_double import RDF
+from sage.rings.real_mpfr import RR
+
 from .delsarte_bounds import (delsarte_bound_hamming_space,
                               delsarte_bound_additive_hamming_space)
 from sage.features.gap import GapPackage

src/sage/coding/code_constructions.py

@@ -40,20 +40,17 @@
 #                  https://www.gnu.org/licenses/
 # ****************************************************************************
 
-from sage.misc.misc_c import prod
-from sage.arith.all import quadratic_residues, gcd
-
-from sage.structure.sequence import Sequence, Sequence_generic
-
-from sage.matrix.matrix_space import MatrixSpace
+from sage.arith.misc import gcd, quadratic_residues
 from sage.matrix.constructor import matrix
+from sage.matrix.matrix_space import MatrixSpace
 from sage.matrix.special import random_matrix
-
+from sage.misc.misc_c import prod
 from sage.rings.finite_rings.finite_field_constructor import FiniteField as GF
 from sage.rings.finite_rings.integer_mod import Mod
 from sage.rings.finite_rings.integer_mod_ring import IntegerModRing
-from sage.rings.polynomial.polynomial_ring_constructor import PolynomialRing
 from sage.rings.integer import Integer
+from sage.rings.polynomial.polynomial_ring_constructor import PolynomialRing
+from sage.structure.sequence import Sequence, Sequence_generic
 
 from .linear_code import LinearCode
 
@@ -753,7 +750,7 @@ def ToricCode(P,F):
 
     - David Joyner (07-2006)
     """
-    from sage.combinat.all import Tuples
+    from sage.combinat.tuple import Tuples
     mset = [x for x in F if x != 0]
     d = len(P[0])
     pts = Tuples(mset, d).list()

src/sage/coding/cyclic_code.py

@@ -41,11 +41,11 @@
 from copy import copy
 from sage.rings.integer import Integer
 from sage.categories.homset import Hom
-from sage.arith.all import gcd
+from sage.arith.misc import gcd
 from sage.modules.free_module_element import vector
 from sage.matrix.constructor import matrix
 from sage.misc.cachefunc import cached_method
-from sage.rings.all import Zmod
+from sage.rings.finite_rings.integer_mod_ring import IntegerModRing as Zmod
 
 
 def find_generator_polynomial(code, check=True):

src/sage/coding/delsarte_bounds.py

@@ -102,7 +102,7 @@ def krawtchouk(n, q, l, x, check=True):
         ...
         TypeError: no conversion of this rational to integer
     """
-    from sage.arith.all import binomial
+    from sage.arith.misc import binomial
     from sage.arith.srange import srange
     # Use the expression in equation (55) of MacWilliams & Sloane, pg 151
     # We write jth term = some_factor * (j-1)th term
@@ -171,7 +171,7 @@ def eberlein(n, w, k, u, check=True):
         TypeError: either m or x-m must be an integer
 
     """
-    from sage.arith.all import binomial
+    from sage.arith.misc import binomial
     from sage.arith.srange import srange
 
     if 2*w > n:
@@ -275,7 +275,7 @@ def _delsarte_cwc_LP_building(n, d, w, solver, isinteger):
 
     """
     from sage.numerical.mip import MixedIntegerLinearProgram
-    from sage.arith.all import binomial
+    from sage.arith.misc import binomial
 
     p = MixedIntegerLinearProgram(maximization=True, solver=solver)
     A = p.new_variable(integer=isinteger, nonnegative=True)
@@ -602,7 +602,6 @@ def _delsarte_Q_LP_building(q, d, solver, isinteger):
     EXAMPLES::
 
         sage: from sage.coding.delsarte_bounds import _delsarte_Q_LP_building
-        sage: from sage.all import *
         sage: q = Matrix([[codes.bounds.krawtchouk(6,2,i,j) for j in range(7)] for i in range(7)])
         sage: _, p = _delsarte_Q_LP_building(q, 2, "PPL", False)
         sage: p.show()

src/sage/coding/information_set_decoder.py

@@ -40,7 +40,11 @@
 #                  http://www.gnu.org/licenses/
 #******************************************************************************
 
-from sage.all import ZZ, Integer, vector, SageObject, binomial
+from sage.rings.integer_ring import ZZ
+from sage.rings.integer import Integer
+from sage.modules.free_module_element import free_module_element as vector
+from sage.structure.sage_object import SageObject
+from sage.functions.other import binomial
 from .decoder import Decoder
 
 

src/sage/coding/linear_code.py

@@ -205,32 +205,33 @@ class should inherit from this class. Also ``AbstractLinearCode`` should never
 import os
 import subprocess
 
-from io import StringIO
 from copy import copy
+from io import StringIO
 
-from sage.cpython.string import bytes_to_str
+from sage.arith.misc import binomial, GCD
 from sage.categories.cartesian_product import cartesian_product
 from sage.categories.fields import Fields
+from sage.coding.decoder import Decoder
+from sage.coding.encoder import Encoder
+from sage.coding.linear_code_no_metric import AbstractLinearCodeNoMetric
+from sage.combinat.subset import Subsets
+from sage.cpython.string import bytes_to_str
+from sage.features.gap import GapPackage
+from sage.groups.all import SymmetricGroup
+from sage.groups.perm_gps.permgroup import PermutationGroup
+from sage.interfaces.gap import gap
 from sage.matrix.matrix_space import MatrixSpace
+from sage.misc.cachefunc import cached_method
+from sage.misc.functional import is_even
+from sage.misc.misc_c import prod
+from sage.misc.randstate import current_randstate
 from sage.modules.free_module import VectorSpace
 from sage.modules.free_module_element import vector
-from sage.arith.all import GCD, binomial
-from sage.groups.all import SymmetricGroup
-from sage.groups.perm_gps.permgroup import PermutationGroup
-from sage.rings.rational_field import QQ
+from sage.rings.finite_rings.finite_field_constructor import FiniteField as GF
+from sage.rings.integer import Integer
 from sage.rings.integer_ring import ZZ
 from sage.rings.polynomial.polynomial_ring_constructor import PolynomialRing
-from sage.rings.integer import Integer
-from sage.rings.finite_rings.finite_field_constructor import FiniteField as GF
-from sage.misc.misc_c import prod
-from sage.misc.functional import is_even
-from sage.misc.cachefunc import cached_method
-from sage.misc.randstate import current_randstate
-from sage.combinat.subset import Subsets
-from sage.features.gap import GapPackage
-from sage.coding.linear_code_no_metric import AbstractLinearCodeNoMetric
-from .encoder import Encoder
-from .decoder import Decoder
+from sage.rings.rational_field import QQ
 
 # *****************************************************************************
 # coding theory functions