Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tensor of CombinatorialFreeModule use cartesian_product, deprecate CartesianProduct_iters #35282

Draft
wants to merge 25 commits into
base: develop
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
fbf7db5
work on CartesianProduct_iter
mkoeppe May 22, 2024
6c88862
src/sage/combinat/cartesian_product.py: Deprecate CartesianProduct_iters
mkoeppe Apr 3, 2024
a9433a7
src/sage/combinat/free_module.py: Update doctests
mkoeppe May 22, 2024
3c7301b
src/sage/homology/hochschild_complex.py: Update doctest output (an_el…
mkoeppe Aug 11, 2022
d4a5c18
LazyFamily.__eq__: Check hashes first, then check repr, then check th…
mkoeppe Aug 12, 2022
8db0fa6
LazyFamily.__eq__: Check hashes of the index sets only, not the hashe…
mkoeppe Aug 13, 2022
cfdf2c4
src/sage/sets/cartesian_product.py: Do not use UniqueRepresentation w…
mkoeppe Aug 12, 2022
314c380
src/sage/sets/cartesian_product.py: Do use UniqueRepresentation when …
mkoeppe Aug 13, 2022
adc577a
src/sage/structure/unique_representation.py: Refactor CachedRepresent…
mkoeppe May 22, 2024
1bc7cd0
src/sage/sets/cartesian_product.py: Remove code duplication
mkoeppe Aug 13, 2022
6fc8f02
src/sage/categories/{sets_cat.py,category_singleton.pyx}: Update doct…
mkoeppe Aug 13, 2022
f7f0ceb
src/sage/sets/cartesian_product.py: Remove unused import
mkoeppe Aug 13, 2022
cafd94a
src/sage/sets/cartesian_product.py: Add doctest for equality (1 failure)
mkoeppe Aug 13, 2022
100b093
src/sage/sets/cartesian_product.py: Implement __eq__, __hash__ for no…
mkoeppe Aug 13, 2022
c176d2f
src/sage/sets/cartesian_product.py (CartesianProduct): Factor through…
mkoeppe Mar 3, 2024
86c16d8
Fix comments
mkoeppe Aug 13, 2022
599036c
src/sage/sets/cartesian_product.py (CartesianProduct): Factor through…
mkoeppe Aug 13, 2022
0422d45
src/sage/sets/cartesian_product.py (CartesianProduct): Dispatch to im…
mkoeppe Aug 14, 2022
b558296
src/sage/combinat/posets/cartesian_product.py: Fixup use of Cartesian…
mkoeppe Aug 14, 2022
7b3ade3
src/sage/sets/cartesian_product.py: Update copyright according to git…
mkoeppe Aug 14, 2022
414ebcf
WIP documentation
mkoeppe Aug 14, 2022
eb7d9b9
src/sage/sets/cartesian_product.py: Make MRO consistent
mkoeppe Aug 17, 2022
b4ff579
src/sage/rings/asymptotic/growth_group_cartesian.py: CartesianProduct…
mkoeppe Aug 17, 2022
7ab3331
src/sage/rings/asymptotic, src/sage/combinat/posets: Replace some sup…
mkoeppe Aug 17, 2022
9b9e276
src/sage/combinat/cartesian_product.py: Update Issue URLs in deprecation
mkoeppe Apr 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src/sage/rings/asymptotic, src/sage/combinat/posets: Replace some sup…
…er().__init__ by direct calls
Matthias Koeppe committed May 27, 2024
commit 7ab3331c20f7ad7e38161ee75dce0e78cf4f87b3
2 changes: 1 addition & 1 deletion src/sage/combinat/posets/cartesian_product.py
Original file line number Diff line number Diff line change
@@ -111,7 +111,7 @@ def __init__(self, sets, category, order=None, **kwargs) -> None:
if not isinstance(category, tuple):
category = (category,)
category = Category.join(category + (Posets(),))
super().__init__(sets, category, **kwargs)
CartesianProduct_unique.__init__(self, sets, category, **kwargs)

def le(self, left, right):
r"""
2 changes: 1 addition & 1 deletion src/sage/rings/asymptotic/growth_group.py
Original file line number Diff line number Diff line change
@@ -1885,7 +1885,7 @@ def __init__(self, base, var, category):
"""
self._var_ = var
super().__init__(category=category, base=base)
Parent.__init__(self, category=category, base=base)

def _repr_short_(self):
r"""
6 changes: 4 additions & 2 deletions src/sage/rings/asymptotic/growth_group_cartesian.py
Original file line number Diff line number Diff line change
@@ -1412,7 +1412,8 @@ def __init__(self, sets, category, **kwargs):
sage: type(GrowthGroup('x^ZZ * log(x)^ZZ')) # indirect doctest
<class 'sage.rings.asymptotic.growth_group_cartesian.UnivariateProduct_with_category'>
"""
super().__init__(sets, category, order='lex', **kwargs)
GenericProduct.__init__(self,
sets, category, order='lex', **kwargs)

CartesianProduct = CartesianProductGrowthGroups

@@ -1443,6 +1444,7 @@ def __init__(self, sets, category, **kwargs):
sage: type(GrowthGroup('x^ZZ * y^ZZ')) # indirect doctest
<class 'sage.rings.asymptotic.growth_group_cartesian.MultivariateProduct_with_category'>
"""
super().__init__(sets, category, order='product', **kwargs)
GenericProduct.__init__(self,
sets, category, order='product', **kwargs)

CartesianProduct = CartesianProductGrowthGroups