Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.quadratic_forms: Modularization fixes for imports #35305

Merged
merged 40 commits into from
Apr 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
6512590
sage.quadratic_forms: Move some imports into methods
mkoeppe Mar 11, 2023
171da1f
src/sage/quadratic_forms/genera/normal_form.py: Mark # optional - sag…
mkoeppe Mar 18, 2023
1c42d4c
src/sage/quadratic_forms/genera/normal_form.py: Move import of Zp int…
mkoeppe Mar 18, 2023
1509ded
src/sage/quadratic_forms/genera/normal_form.py: Cosmetic fixes in doc…
mkoeppe Mar 18, 2023
ca4ef1f
src/sage/quadratic_forms/genera/genus.py: Move imports from sage.func…
mkoeppe Oct 18, 2021
d6f8be7
src/sage/quadratic_forms: Move imports from sage.functions into methods
mkoeppe Oct 19, 2021
b81d0b0
src/sage/quadratic_forms: Move imports from sage.symbolic, sage.funct…
mkoeppe Mar 18, 2023
874d6b6
Remove some imports from sage.functions
mkoeppe Jan 31, 2023
5eda77a
src/sage/modules/free_quadratic_module_integer_symmetric.py: Move imp…
mkoeppe Feb 20, 2023
d1479f1
src/sage/quadratic_forms/binary_qf.py: Fix up # optional
mkoeppe Mar 18, 2023
e2093f6
sage.quadratic_forms: Mark doctests # optional
mkoeppe Mar 19, 2023
ac09b7f
sage.quadratic_forms: Move some imports into methods
mkoeppe Mar 19, 2023
17a7eb7
src/sage/quadratic_forms/quadratic_form__neighbors.py: Fix # optional
mkoeppe Mar 19, 2023
e02020a
src/sage/quadratic_forms/__init__.py: Remove - make a namespace package
mkoeppe Mar 19, 2023
cc36443
src/sage/quadratic_forms/quadratic_form.py: Use lazy_import for impor…
mkoeppe Mar 19, 2023
0f3c795
Deprecate is_QuadraticForm, remove QuadraticForm__constructor
mkoeppe Mar 19, 2023
391bd94
sage.modules, sage.quadratic_forms: More # optional
mkoeppe Mar 20, 2023
c8e1cb6
sage.quadratic_forms: Make more imports lazy
mkoeppe Mar 20, 2023
f3d33a0
src/sage/quadratic_forms/binary_qf.py: Remove unused import
mkoeppe Mar 31, 2023
5feb970
Merge tag '10.0.beta8' into sage_quadratic_forms_modularization
mkoeppe Apr 7, 2023
1af68d4
src/sage/modules/fg_pid/fgp_module.py: Docstring cosmetics
mkoeppe Apr 10, 2023
01479cb
src/sage/modules/free_quadratic_module_integer_symmetric.py: Docstrin…
mkoeppe Apr 10, 2023
be0b1e2
src/sage/quadratic_forms/quadratic_form__mass__Siegel_densities.py: F…
mkoeppe Apr 10, 2023
b601e06
sage.quadratic_forms: More doctest cosmetics
mkoeppe Apr 10, 2023
6e14ab8
src/sage/quadratic_forms/quadratic_form__local_density_congruence.py:…
mkoeppe Apr 10, 2023
15f0936
src/sage/modules/fg_pid/fgp_module.py: Reviewer-suggested sphinx mark…
mkoeppe Apr 12, 2023
f4a2e0c
sage.quadratic_forms: Double-quote input arguments and other markup f…
mkoeppe Apr 12, 2023
27666ca
sage.quadratic_forms: More markup fixes in docstrings
mkoeppe Apr 12, 2023
e9c0152
sage.quadratic_forms: Some more markup fixes in docstrings
mkoeppe Apr 12, 2023
d290b12
sage.quadratic_forms: More markup fixes in docstrings
mkoeppe Apr 12, 2023
ec951b8
sage.quadratic_forms: In docstrings, use math mode for Q
mkoeppe Apr 12, 2023
bf42a6b
sage.quadratic_forms: More docstring markup improvements
mkoeppe Apr 13, 2023
3656c53
src/sage/quadratic_forms/ternary_qf.py: Revert adding :meth: markup t…
mkoeppe Apr 13, 2023
2ebcd7e
src/sage/quadratic_forms/quadratic_form__*.py: Re-align modularizatio…
mkoeppe Apr 13, 2023
828b059
sage.quadratic_forms: A few more docstring markup improvements
mkoeppe Apr 13, 2023
d91a795
src/sage/quadratic_forms: Reviewer-suggested sphinx markup changes
mkoeppe Apr 13, 2023
4ee52e2
src/sage/quadratic_forms: Doctest cosmetics
mkoeppe Apr 13, 2023
17a02c3
Merge remote-tracking branch 'upstream/develop' into sage_quadratic_f…
mkoeppe Apr 13, 2023
33899aa
src/sage/quadratic_forms: Reviewer-suggested sphinx markup changes
mkoeppe Apr 14, 2023
a937a04
src/sage/quadratic_forms: Use \cdot for multiplication
mkoeppe Apr 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sage/dynamics/arithmetic_dynamics/berkovich_ds.py
Original file line number Diff line number Diff line change
Expand Up @@ -926,7 +926,7 @@ def __call__(self, x, type_3_pole_check=True):
variable = nth_derivative.parent().gens()[0]
a = x.center()[0]
Taylor_expansion = []
from sage.functions.other import factorial
from sage.arith.misc import factorial
for i in range(f.degree() + 1):
Taylor_expansion.append(nth_derivative(a) * 1/factorial(i))
nth_derivative = nth_derivative.derivative(variable)
Expand Down
2 changes: 1 addition & 1 deletion src/sage/groups/misc_gps/argument_groups.py
Original file line number Diff line number Diff line change
Expand Up @@ -1192,7 +1192,7 @@ def __pow__(self, exponent):
sage: a.parent()
Symbolic Ring
"""
from sage.symbolic.ring import SymbolicRing
from sage.rings.abc import SymbolicRing

element = self._element_ ** exponent
parent = element.parent()
Expand Down
6 changes: 2 additions & 4 deletions src/sage/modular/arithgroup/congroup_gamma0.py
Original file line number Diff line number Diff line change
Expand Up @@ -593,8 +593,6 @@ def dimension_new_cusp_forms(self, k=2, p=0):
sage: all(Gamma0(N).dimension_new_cusp_forms(2)==100 for N in L)
True
"""
from sage.functions.other import floor

N = self.level()
k = ZZ(k)

Expand Down Expand Up @@ -669,8 +667,8 @@ def v3(q, a):

res = (k - 1) / 12 * N * prod(s0(q, a) for q, a in factors)
res -= prod(vinf(q, a) for q, a in factors) / ZZ(2)
res += ((1 - k)/4 + floor(k/4)) * prod(v2(q, a) for q, a in factors)
res += ((1 - k)/3 + floor(k/3)) * prod(v3(q, a) for q, a in factors)
res += ((1 - k)/4 + k//4) * prod(v2(q, a) for q, a in factors)
res += ((1 - k)/3 + k//3) * prod(v3(q, a) for q, a in factors)
if k == 2:
res += moebius(N)
return res
Loading