Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.graphs: More modularization #35718

Merged
merged 6 commits into from
Jun 11, 2023
Merged

sage.graphs: More modularization #35718

merged 6 commits into from
Jun 11, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 4, 2023

📚 Description

Mostly using lazy_import and adding # optional annotations to doctests.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Jun 4, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 4, 2023

The linter failures are not coming from the PR.

@mkoeppe mkoeppe requested a review from dcoudert June 4, 2023 15:20
dcoudert
dcoudert suggested changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted a few places in which the alignement of the # optional ... is different than in the other files. Otherwise, this looks good to me. I also checked the examples you changed and this seems ok.

src/sage/graphs/generic_graph.py Outdated
@@ -19490,8 +19538,8 @@ def latex_options(self):
sage: opts = g.latex_options()
sage: opts
LaTeX options for Petersen graph: {}
sage: opts.set_option('tkz_style', 'Classic')
sage: opts
sage: opts.set_option('tkz_style', 'Classic') # optional - sage.plot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different alignment

src/sage/graphs/generic_graph.py Outdated
sage: g.set_latex_options(tkz_style='Welsh')
sage: opts = g.latex_options()
sage: opts.get_option('tkz_style')
sage: g.set_latex_options(tkz_style='Welsh') # optional - sage.plot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different alignment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting these! Fixed now.

@mkoeppe mkoeppe force-pushed the sage_graphs_more_modularization branch from e519145 to 2891cd8 Compare June 4, 2023 16:40
@github-actions
Copy link

github-actions bot commented Jun 4, 2023

Documentation preview for this PR (built with commit 2891cd8) is ready! 🎉

dcoudert
dcoudert approved these changes Jun 4, 2023
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 4, 2023

Thank you!

@vbraun vbraun merged commit 6d1cb7e into sagemath:develop Jun 11, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: graph theory t: refactoring
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @dcoudert @vbraun