-
-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.combinat
: Split some Cython modules (modularization fixes)
#35741
sage.combinat
: Split some Cython modules (modularization fixes)
#35741
Conversation
@dcoudert, from #35564 (comment):
I don't know; the source file from which I split it out did not have this directive if I'm not mistaken. I'll be happy to add it to if you recommend it? |
I had to add |
Documentation preview for this PR (built with commit fe07439) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks a lot for reviewing! |
📚 Description
Some basic modules of
sage.combinat
(.permutation
,.combination
, etc.) are needed in the distribution sagemath-categories (as of #35095). We make them importable (by splitting a Cython module into several parts and by using lazy imports) and separately testable (using# optional
doctest directives).Likewise, split the parts of
sage.combinat.posets.hasse_cython
that need the FLINT library out as a separate module (this is for the package sagemath-graphs in #35095)sage.misc.misc
,sage.combinat
: Modularization fixes #35564📝 Checklist
⌛ Dependencies