Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgs/sagemath-meataxe/README.rst: Remove markup unknown to PyPI #36003

Merged
merged 1 commit into from
Aug 5, 2023
Merged

pkgs/sagemath-meataxe/README.rst: Remove markup unknown to PyPI #36003

merged 1 commit into from
Aug 5, 2023

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jul 30, 2023

This fixes a failure that currently stops our distributions from being published to PyPI:
https://github.com/sagemath/sage/actions/runs/5706565883/job/15462388715#step:7:28

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe mkoeppe requested a review from kiwifb July 30, 2023 18:43
@mkoeppe mkoeppe self-assigned this Jul 30, 2023
@mkoeppe mkoeppe requested a review from antonio-rojas July 30, 2023 19:14
@github-actions
Copy link

Documentation preview for this PR (built with commit f31ff72; changes) is ready! 🎉

@kiwifb
Copy link
Member

kiwifb commented Jul 30, 2023

How come there was no problems for the initial 10.0 release you made? Was it because you pushed manually?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 30, 2023

I probably introduced this markup problem after pushing the 10.0 releases (manually built from the #35661 branch).

kiwifb
kiwifb approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@kiwifb kiwifb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 30, 2023

Thank you!

@vbraun vbraun merged commit 23c0808 into sagemath:develop Aug 5, 2023
@mkoeppe mkoeppe added this to the sage-10.1 milestone Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiwifb kiwifb kiwifb approved these changes

@antonio-rojas antonio-rojas Awaiting requested review from antonio-rojas

Assignees

@mkoeppe mkoeppe

Labels
c: distribution p: critical / 2
Projects
None yet
Milestone
sage-10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @kiwifb @vbraun