Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.features.sat #38239

Merged
merged 1 commit into from
Jul 24, 2024
Merged

sage.features.sat #38239

merged 1 commit into from
Jul 24, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 19, 2024 •
edited
Loading

Part of:

To be done in a follow-up:

  • Actually use Executable.absolute_filename when invoking the Dimacs solvers.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@mkoeppe mkoeppe self-assigned this Jun 19, 2024
@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit bd4724e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe mkoeppe requested a review from seblabbe June 19, 2024 01:46
@mkoeppe mkoeppe marked this pull request as ready for review June 19, 2024 01:46
kwankyu
kwankyu approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 19, 2024

Thanks!

seblabbe
seblabbe approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@seblabbe seblabbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2024

Thank you.

@vbraun vbraun merged commit 8a7827c into sagemath:develop Jul 24, 2024
29 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Jul 25, 2024
@mkoeppe mkoeppe deleted the sat_features branch July 25, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

@seblabbe seblabbe seblabbe approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: combinatorics c: doctest framework t: refactoring v: small
Projects
None yet
Milestone
sage-10.5
Development

Successfully merging this pull request may close these issues.
4 participants
@mkoeppe @kwankyu @seblabbe @vbraun