Tweak a few tests to pass when giac is not installed #38690
Conversation
Various implementations get it a little (1e-10) different.
…wers We have an integration test in this file that is looking for the giac result, but sympy gives an equivalent one. We should accept that, too.
There's one piecewise test that uses algorithm='giac', but it will soon be possible to install sage without giac. We could make the test conditional on giac's presence, but the same thing works with sympy, so let's just use that.
|
Documentation preview for this PR (built with commit df6d309; changes) is ready! 🎉 |
|
As always, the CI fails are bogus/unrelated. |
|
There will be a PR where I add a bunch of "needs" tags, but in these few cases I was able to update the expected output to work both with/without giac, so a new "needs" tag isn't necessary. Sympy is a standard package and our "integrate" commands already use it unconditionally; so long as nobody adds a It's unrelated to this issue, but integrating with We're also missing a way to detect the giac pexpect interface, but I've added that in #38672. In theory you could have the executable installed but not the library... some binary distros have been known to split packages up like this. |
|
Sure, thanks for the review! |
sagemathgh-38690: Tweak a few tests to pass when giac is not installed This is one of the prerequisites to make it possible to install sage without giac (sagemath#38668). These few tests can be made to work easily without a `# needs giac`, so let's do that. URL: sagemath#38690 Reported by: Michael Orlitzky Reviewer(s): David Coudert
This is one of the prerequisites to make it possible to install sage without giac (#38668). These few tests can be made to work easily without a
# needs giac, so let's do that.