Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug option to check category MRO #39170

Draft
wants to merge 30 commits into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Dec 19, 2024

To avoid headaches like #39154 in the future.

TODO: set this option to False by default.

TODO: make the test actually pass for homset. As the documentation says "currently this doesn't work with homset"…

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Dec 19, 2024

Documentation preview for this PR (built with commit be85943; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729
Copy link
Contributor Author

user202729 commented Dec 20, 2024

The caching really breaks a lot of things.

sage: MatrixSpace(SR, 2).category()
Category of infinite finite dimensional algebras with basis over commutative rings
sage: SR.category()
Category of commutative rings
sage: VectorSpaces(SR)
Category of vector spaces over Symbolic Ring
sage: SR.category()
Category of fields
sage: MatrixSpace(SR, 2).category()  # cached!
Category of infinite finite dimensional algebras with basis over commutative rings
sage: MatrixSpace(SR, 3).category()
Category of infinite finite dimensional algebras with basis over fields

Of course with the band aid this particular one is fixed but…

Might be a better idea to use the category with axiom framework, whatever it may mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant