Skip to content

removing some unused imports in pyx files #39635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

fchapoton
Copy link
Contributor

found using
cython-lint --ignore=E501,E741,E231,E265 src/sage/ | grep imported

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link

github-actions bot commented Mar 5, 2025

Documentation preview for this PR (built with commit 53d5662; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I don't understand why networkx is used in src/sage/matroids/transversal_matroid.pyx instead of Digraph. This should be investigated in a future PR to possibly improve the code.

vbraun pushed a commit to vbraun/sage that referenced this pull request Mar 9, 2025
found using
`
cython-lint --ignore=E501,E741,E231,E265 src/sage/ | grep imported
`
### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.

URL: sagemath#39635
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit 765b1ab into sagemath:develop Mar 9, 2025
23 checks passed
@fchapoton fchapoton deleted the unused_imports_pyx branch March 11, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants