Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reduce_to_unit method to GaussValuation, fixes #39702 #39719

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

5iri
Copy link

@5iri 5iri commented Mar 16, 2025

This pull request addresses issue #39702 by adding a reduce_to_unit method to the GaussValuation class in SageMath. The method simplifies reducing the unit part of an element to valuation 0, which was previously a tedious process.

Changes Made:

  • Added reduce_to_unit method to src/sage/rings/valuation/gauss_valuation.py.
  • The method shifts the element's valuation to 0 using equivalence_unit and then reduces it.
  • Fixed handling of infinite valuations by comparing with infinity from sage.rings.infinity.

image

@5iri 5iri marked this pull request as draft March 16, 2025 13:42
@5iri 5iri marked this pull request as ready for review March 16, 2025 13:48
@5iri 5iri marked this pull request as draft March 16, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant