Add a note on implementation of double-underscore methods #39725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user202729
changed the title
|
Documentation preview for this PR (built with commit 464f559; changes) is ready! 🎉 |
user202729
force-pushed
the
note-double-underscore
branch
from
e268f70 to
464f559
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted, the listed double-underscore methods should be directly implemented by subclasses.
I don't know if we actually want
__neg__to be like that, or should we just take it out like__invert__. Having__neg__in is just API consistency at the cost of performance; and then the API isn't entirely consistent either, for there is__str__not provided byElement.📝 Checklist
⌛ Dependencies