Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize AdditiveMonoids sum() method #39726

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Mar 17, 2025

Previously the example shown takes way too long. Now it takes 0.5s.

It is probably possible to optimize further by specialize it using Singular.

Opinion: how should the iterator multiplication be implemented

  • as is (disadvantage: slightly misleading method name),
  • copy paste the code logic of iterator_prod and make a new method iterator_sum (disadvantage: code duplication),
  • make an internal method _iterator_combine that takes bint multiply, then make iterator_prod and iterator_sum call it (disadvantage: potential slower branching each operation, but should be negligible)

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit a6290fe; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant