Optimize AdditiveMonoids sum() method #39726
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the example shown takes way too long. Now it takes 0.5s.
It is probably possible to optimize further by specialize it using Singular.
Opinion: how should the iterator multiplication be implemented
iterator_prod
and make a new methoditerator_sum
(disadvantage: code duplication),_iterator_combine
that takesbint multiply
, then makeiterator_prod
anditerator_sum
call it (disadvantage: potential slower branching each operation, but should be negligible)📝 Checklist
⌛ Dependencies