Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ticket links in wiki conversion #183

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

kwankyu
Copy link

@kwankyu kwankyu commented Feb 6, 2023

Fixes #73 (comment)

Perhaps it's not too late. With this PR merged, we convert trac wiki pages again with right ticket links, and then merge with existing github wiki pages. There may be some conflicts because people already edited some part of the github wiki pages. But it would be much easier to fix these merge conflicts than manually editing all ticket links in github wiki pages manually!

@mkoeppe
Copy link

mkoeppe commented Feb 6, 2023

Yes, that's a great way to do this.

@mkoeppe mkoeppe merged commit 5cf3107 into sagemath:master Feb 6, 2023
@mkoeppe
Copy link

mkoeppe commented Feb 6, 2023

Do you plan to make this commit to the wiki, or do you want me to do this?

@kwankyu
Copy link
Author

kwankyu commented Feb 6, 2023

I would be happy if you do it.

@kwankyu kwankyu deleted the fix-ticket-link-in-wiki branch February 6, 2023 19:35
@mkoeppe
Copy link

mkoeppe commented Feb 6, 2023

Done.

@kwankyu
Copy link
Author

kwankyu commented Feb 6, 2023

Thanks. Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Switchover from Trac to GitHub
2 participants