Update boxcar #696
Merged
Update boxcar #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #696 will improve performances by 3.09%Comparing Summary
Benchmarks breakdown
|
|
The CodSpeed regression is interesting.. I see a very clear improvement locally. |
|
Maybe one way to handle the noise from codespeed is to look at instruction counts before/after the change? |
ibraheemdev
force-pushed
the
boxcar-alloc-zeroed
branch
from
ec6b6c5 to
27cf84a
Compare
ibraheemdev
force-pushed
the
boxcar-alloc-zeroed
branch
from
27cf84a to
1c301d2
Compare
|
Looks like this is a win across the board now. I suspect that's due to #725. I'm not sure what allocator CodSpeed was using previously, but the change should be a clear improvement. |
Veykril
approved these changes
Mar 20, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the reason for the regression in #688 might have been simpler than I thought and come down to some poor codegen when allocating new boxcar buckets (see ibraheemdev/boxcar#28). Hoping CodSpeed also picks up these changes.