Skip to content
This repository was archived by the owner on Oct 26, 2022. It is now read-only.

[WIP] Update code&links to Julia 1.0 #26

Merged
merged 15 commits into from
Oct 16, 2019

Conversation

inkydragon
Copy link
Contributor

@inkydragon inkydragon commented Sep 2, 2018

  • All example code test in Julia v"1.0.0" without any warning or error;
  • All doc links point to [email protected];
  • All links use https;
  • Update addcomments.jl;
  • Update comments with the output of the code;
  • Update .travis.yml if need;
  • Build & Check output website.

fix #25 , fix #27

1. All code test in Julia v"1.0.0" without any warning or error;
2. Most links point to [email protected];
3. All links use https;
1. Use `with open` block
2. use py3-style `print()`
1. testing `addcomment.jl`
2. update code output using command line' output
3. using new example in `error_handling.jl`
1. Using Julia 1.0
2. Tested for all `*.jl`, but some output has difference from command line's output
3. Cannot remove comment at end of some code
@XVilka
Copy link
Contributor

XVilka commented Jun 9, 2019

@samuelcolvin ping?

@samuelcolvin
Copy link
Owner

Sorry the project is slightly abandoned.

I'll try and merge and deploy next week.

@XVilka
Copy link
Contributor

XVilka commented Oct 15, 2019

@samuelcolvin can you please check this PR again?

@samuelcolvin
Copy link
Owner

Hi @XVilka, sorry for the slow response.

I'm not writing any julia at the moment and pretty busy with other open source projects.

Is there any change you could get tests to pass? The problem seems to be with the "winston" plotting package.

@XVilka
Copy link
Contributor

XVilka commented Oct 16, 2019

Maybe it makes sense to update to Julia 1.2.0? Pure 1.0.0 is quite old, and there were some improvements since.

@inkydragon
Copy link
Contributor Author

Pure 1.0.0 is quite old

v1.0.5 is Long-term support version. We just need to wait until next LTS version comes out.
And I thinks most of those code works well in 1.2.0, maybe some pkg will fail.

@samuelcolvin samuelcolvin merged commit 0410f7b into samuelcolvin:master Oct 16, 2019
@samuelcolvin
Copy link
Owner

thank you very much. I'll try and get the new version deployed soon.

@samuelcolvin
Copy link
Owner

tests fixed and deployed. From now on the site can simply be deployed by merging to master, making changes much easier.

@inkydragon inkydragon deleted the Julia-1.0 branch October 16, 2019 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Julia 1.0 - Converting Example not compatible with v1.0
3 participants