-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Build: Adding libsass.gyp in a separate dir #818
Conversation
* Turned out it isn't a bug, it's a feature! * npm/npm#7780
Build: Adding libsass.gyp in a separate dir
Thanks! Yes, I can build with external |
Yeah, just waiting for libsass beta.next. I will add this feature: sass/libsass#1000 (comment) in the next beta. Separately, do you think you can arrange FreeBSD binaries for existing beta sass/node-sass-binaries#50? |
Ok, working on it! |
Regarding packaging: it would be really good for things like "npm install " to include an already build binary in the npm package. But that kind of introduces two kinds of package tarfiles - source only and source + specific binary. |
Great thanks! :) Remember, nvm is your friend for fast version switching. Also, now the Dockerfile is promising for Linux binaries: https://gist.github.com/am11/1529b2458b1a1f4bdba8, would be nice if we have similar recipe for FreeBSD and solaris too. Related: https://github.com/sass/node-sass-binaries/issues/32#issuecomment-87361249 (I tired, but seem to can't configure solaris VM..). |
My recipe is to run:
where |
Yes we used to bundle binary in the before node-sass-binaries repo, but turned out separating binaries from package is a good practice, which most of the packages using add-ons have adapted. One reason I remember was that the package is a distilled form, and we cannot cherry pick the platform specific binary at install time (altering the package on the fly). So it would be a real bulky package if we bundle all binaries in it. With current approach, we can add binaries for specific release even after publishing. |
Looks nice. Our current matrix requirement is:
Can you release 32-bit bins as well? |
Perhaps this is worth giving a shot: https://registry.hub.docker.com/u/kazuyoshi/freebsd-minimal/tags/manage/ (FreeBSD docker container). Our recipe files will eventually be added to node-sass-binaries repo. For Windows, I will make a |
@saper, how are the FreeBSD builds coming along? Feel free to send a PR at node-sass-binaries like https://github.com/sass/node-sass-binaries/issues/32. :) |
Very good, just need to restore old FreeBSD iojs 1.0.4 port out of the dustbin, since all others are ready. |
👍 |
Normalise CSS function string arguments to double quotes
//cc @saper.