Skip to content
This repository was archived by the owner on Jul 24, 2024. It is now read-only.

Build: Adding libsass.gyp in a separate dir #818

Merged
merged 1 commit into from
Mar 29, 2015
Merged

Conversation

am11
Copy link
Contributor

@am11 am11 commented Mar 29, 2015

* Turned out it isn't a bug, it's a feature!
  * npm/npm#7780
am11 added a commit that referenced this pull request Mar 29, 2015
Build: Adding libsass.gyp in a separate dir
@am11 am11 merged commit 5d5dff4 into sass:master Mar 29, 2015
@saper
Copy link
Member

saper commented Mar 29, 2015

Thanks! Yes, I can build with external libsass now without problems. (this time against 3.2.0beta1+)

@am11
Copy link
Contributor Author

am11 commented Mar 29, 2015

Yeah, just waiting for libsass beta.next. I will add this feature: sass/libsass#1000 (comment) in the next beta.

Separately, do you think you can arrange FreeBSD binaries for existing beta sass/node-sass-binaries#50?

@saper
Copy link
Member

saper commented Mar 29, 2015

Ok, working on it!

@saper
Copy link
Member

saper commented Mar 29, 2015

Regarding packaging: it would be really good for things like "npm install " to include an already build binary in the npm package. But that kind of introduces two kinds of package tarfiles - source only and source + specific binary.

@am11
Copy link
Contributor Author

am11 commented Mar 29, 2015

Great thanks! :)

Remember, nvm is your friend for fast version switching. Also, now the Dockerfile is promising for Linux binaries: https://gist.github.com/am11/1529b2458b1a1f4bdba8, would be nice if we have similar recipe for FreeBSD and solaris too. Related: https://github.com/sass/node-sass-binaries/issues/32#issuecomment-87361249 (I tired, but seem to can't configure solaris VM..).

@saper
Copy link
Member

saper commented Mar 29, 2015

My recipe is to run:

for a in i386 amd64
do
        for j in 8_4 9_3 10_1
        do
               for e in nodejs iojs nodejs010
                do
                        poudriere bulk -j "${e}_${j}_${a}" -p exp textproc/node-sass
                done
        done
done

where exp is my experimental port tree with libsass beta and node-sass
and *nodejs* *iojs* *nodejs010* directories are configured to use the respective engines.

@am11
Copy link
Contributor Author

am11 commented Mar 29, 2015

Yes we used to bundle binary in the before node-sass-binaries repo, but turned out separating binaries from package is a good practice, which most of the packages using add-ons have adapted.

One reason I remember was that the package is a distilled form, and we cannot cherry pick the platform specific binary at install time (altering the package on the fly). So it would be a real bulky package if we bundle all binaries in it.

With current approach, we can add binaries for specific release even after publishing.

@am11
Copy link
Contributor Author

am11 commented Mar 29, 2015

Looks nice. Our current matrix requirement is:

  • node.js v0.10.38 (ia32, x64)
  • node.js v0.12.1 (ia32, x64)
  • io.js v1.0.4 (ia32, x64)
  • io.js v1.6.2 (ia32, x64)

Can you release 32-bit bins as well?

@am11
Copy link
Contributor Author

am11 commented Mar 29, 2015

Perhaps this is worth giving a shot: https://registry.hub.docker.com/u/kazuyoshi/freebsd-minimal/tags/manage/ (FreeBSD docker container).

Our recipe files will eventually be added to node-sass-binaries repo.

For Windows, I will make a bat or ps1 script.

@am11
Copy link
Contributor Author

am11 commented Apr 2, 2015

@saper, how are the FreeBSD builds coming along? Feel free to send a PR at node-sass-binaries like https://github.com/sass/node-sass-binaries/issues/32. :)

@saper
Copy link
Member

saper commented Apr 2, 2015

Very good, just need to restore old FreeBSD iojs 1.0.4 port out of the dustbin, since all others are ready.

@am11
Copy link
Contributor Author

am11 commented Apr 2, 2015

👍

jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
Normalise CSS function string arguments to double quotes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants