Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for content-exists in control statements #1361

Closed
wants to merge 1 commit into from
Closed

Add specs for content-exists in control statements #1361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 spec/core_functions/content-exists/basic.hrx → ..._functions/content-exists/basic/basic.hrx
View file
Open in desktop
File renamed without changes.
0 spec/core_functions/content-exists/error.hrx → ..._functions/content-exists/basic/error.hrx
View file
Open in desktop
File renamed without changes.
28 changes: 28 additions & 0 deletions spec/core_functions/content-exists/controls/controls.hrx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<===> input.scss
@mixin test-content-exists() {
@if content-exists() {
@content;
}
@else {
content-exists: false;
}
}

.should-be-true {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I'd call these classes .with-content and .without-content. It's already clear what the expected result is, since it's right there in the output file, so it's more useful to document what's meaningfully different about how they're invoked.

Actually, when you split these into separate specs, you should probably put with_content and without_content into the test names and just make these selector names a.

@include test-content-exists() {
content-exists: true;
}
}

.should-be-false {
@include test-content-exists();
}

<===> output.css
.should-be-true {
content-exists: true;
}

.should-be-false {
content-exists: false;
}