DynamoDB support #244
DynamoDB support #244
Conversation
…niversal-scalardl Remove Cassandra dependencies from universal/scalardl module
Add `database` and `database_contact_port` variables to the universal/scalardl module
The DynamoDB resion should be specified in `database_contact_points` instead since scalardb uses contact_points as a region.
…-image Add trigger for schema_loader_image
…rsal-scalardl Add database options to aws/azure/universal scalardl modules
…hema-loader Upgrade scalar-ledger and scalardl-schema-loader to support DynamoDB
|
I will work on fixing the failing GitHub Actions test. |
|
#246 should fix the test. |
Fix local variable in aws/scalardl module
|
Merged master to make checks pass |
| "%s %s", | ||
| "docker run --rm ${var.schema_loader_image} -h ${var.database_contact_points} -u ${var.database_username} -p ${var.database_password}", | ||
| var.database == "cassandra" ? "--cassandra -P ${var.database_contact_port} -n NetworkTopologyStrategy -R ${var.cassandra_replication_factor}" : | ||
| var.database == "dynamo" ? "--dynamo --region ${var.database_contact_points}" : |
There was a problem hiding this comment.
We are working on adding Cosmos DB support in a later PR, right?
There was a problem hiding this comment.
Currently, only the schema-loading chart in scalar-k8s can load the schema to Cosmos DB, and I don't think we have any plans to support Cosmos DB by scalar-terraform for now.
There was a problem hiding this comment.
Are you just saying we don't have plans for Cosmos DB support in scalar-terraform, but it can be done easily like DynamoDB? Or it is difficult to do it?
There was a problem hiding this comment.
Right, we focused on k8s to support Cosmos DB so far. I think it's going to be easy to do it in scalar-terraform as well.
|
Working on resolving the conflicts. |
https://scalar-labs.atlassian.net/browse/DLT-7415
A PR to merge PRs already merged to the
dynamodbbranch (#232, #238, #237, and #242) to themaster.