This repository was archived by the owner on Aug 28, 2024. It is now read-only.
chore: loosen the types #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cc3b850 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
#71 Bundle Size — 114.09KiB (0%).Bundle metrics
|
| Current #71 |
Baseline #68 |
|
|---|---|---|
 Initial JS |
114.09KiB |
114.09KiB |
| Initial CSS |
0B |
0B |
| Cache Invalidation |
0% |
0% |
| Chunks |
44 |
44 |
| Assets |
44 |
44 |
| Modules |
44 |
44 |
| Duplicate Modules |
0 |
0 |
| Duplicate Code |
0% |
0% |
| Packages |
0 |
0 |
| Duplicate Packages |
0 |
0 |
|
I don’t like this solution. Need to think about what we really want. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to type the specification we get from the user so we have an autocomplete in the IDE. But we also have to expect that the user doesn’t adhere to the OpenAPI specification, so any attribute can be passed on any level.
This isn’t as beautiful as it could be, but works for now. 😬 I’ll go over the types again ASAP.