Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

chore: improve types #122

Merged
merged 4 commits into from
Jun 10, 2024
Merged

chore: improve types #122

merged 4 commits into from
Jun 10, 2024

Conversation

hanspagel
Copy link
Member

@hanspagel hanspagel commented Jun 10, 2024

This PR deletes all @ts-ignore comments and all but one @ts-expect-error comments.

The remaining TypeScript error is caused by a package, that comes without types. It’s only used in the demo.

Doesn’t impact the published types.

@hanspagel hanspagel requested a review from marclave June 10, 2024 11:41
Copy link

changeset-bot bot commented Jun 10, 2024

⚠️ No Changeset found

Latest commit: 0a6a28c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Jun 10, 2024

Deploying openapi-parser with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0a6a28c
Status: ✅  Deploy successful!
Preview URL: https://3de40545.openapi-parser.pages.dev
Branch Preview URL: https://chore-types.openapi-parser.pages.dev

View logs

Copy link

relativeci bot commented Jun 10, 2024

#80 Bundle Size — 114.71KiB (~-0.01%).

0a6a28c(current) vs 84e91c7 main#79(baseline)

Bundle metrics  Change 2 changes Improvement 1 improvement
                 Current
#80
     Baseline
#79
Improvement  Initial JS 114.71KiB(~-0.01%) 114.71KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 1.81% 0%
No change  Chunks 45 45
No change  Assets 45 45
No change  Modules 45 45
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Improvement 1 improvement
                 Current
#80
     Baseline
#79
Improvement  JS 114.71KiB (~-0.01%) 114.71KiB

Bundle analysis reportBranch chore/typesProject dashboard

Copy link
Member

@marclave marclave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥 🔥 🔥 🔥

@marclave marclave merged commit 72703c8 into main Jun 10, 2024
8 checks passed
@marclave marclave deleted the chore/types branch June 10, 2024 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants