Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

fix: ajv import broken #123

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix: ajv import broken #123

merged 2 commits into from
Jun 10, 2024

Conversation

hanspagel
Copy link
Member

@hanspagel hanspagel commented Jun 10, 2024

I’ve received this error in a CommonJS environment:

[ERROR] Client bundle compiled with errors therefore further build is impossible.

Module not found: Error: Can't resolve 'ajv/dist/2020' in '/Users/hanspagel/Documents/Projects/scalar/node_modules/.pnpm/@scalar[email protected]/node_modules/@scalar/openapi-parser/dist/src/lib/Validator'

Did you mean '2020.js'?

BREAKING CHANGE: The request 'ajv/dist/2020' failed to resolve only because it was resolved as fully specified

This PR imports from *.js, this should fix the error.

Copy link

changeset-bot bot commented Jun 10, 2024

🦋 Changeset detected

Latest commit: d108590

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scalar/openapi-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hanspagel hanspagel requested a review from marclave June 10, 2024 14:37
Copy link

relativeci bot commented Jun 10, 2024

#81 Bundle Size — 114.71KiB (~+0.01%).

d108590(current) vs 84e91c7 main#79(baseline)

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#81
     Baseline
#79
Regression  Initial JS 114.71KiB(~+0.01%) 114.71KiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 2.7% 0%
No change  Chunks 45 45
No change  Assets 45 45
No change  Modules 45 45
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#81
     Baseline
#79
Regression  JS 114.71KiB (~+0.01%) 114.71KiB

Bundle analysis reportBranch fix/ajv-importProject dashboard

Copy link
Member

@marclave marclave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix @hanspagel !

@marclave marclave merged commit c6944f2 into main Jun 10, 2024
8 checks passed
@marclave marclave deleted the fix/ajv-import branch June 10, 2024 16:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants