This repository was archived by the owner on Aug 28, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 10595a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Deploying openapi-parser with
|
Latest commit: |
10595a3
|
Status: | ✅ Deploy successful! |
Preview URL: | https://3cb6130b.openapi-parser.pages.dev |
Branch Preview URL: | https://feat-throw-on-error.openapi-parser.pages.dev |
#109 Bundle Size — 116.41KiB (+1.7%).Bundle metrics
Bundle analysis report Branch feat/throw-on-error Project dashboard |
marclave
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we’re introducing the new option
throwOnError
which can be passed toopenapi()
,validate()
anddereference()
to make them throw an exception on the first error that they find.The default is still to just deal with whatever is passed, but for some use cases we might want a stricter version.
Inspiration: #136
Note: This also adds the opportunity to add more options in the future. 👀