This repository was archived by the owner on Aug 28, 2024. It is now read-only.
fix(openapi-parser): add TypeScript discriminator strings #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 35e519e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tmcw
force-pushed
the
add-version-strings
branch
from
ce55668 to
2549ea4
Compare
hanspagel
changed the title
hanspagel
approved these changes
Jul 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently, it's hard to figure out what version of OpenAPI spec you've got, and the spec types are combined together, which makes it hard to interact with the schema object.
Explanation
This happens because the types for the documents don't have literal version strings, and the way they're combined mushes them together.
Solution
With this PR each OpenAPI version gets a literal version string and the types are combined in a simpler way.