Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

feat: type custom extensions, custom extensions in schemas #166

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

hanspagel
Copy link
Member

@hanspagel hanspagel commented Aug 1, 2024

This PR adds two features to the OpenAPI types:

You can now type custom extensions (or any other attribute) like shown here. This doesn’t work on all depth levels yet, I’ll ff with more changes/refactoring.

Screenshot 2024-08-01 at 12 40 52

With this PR, you can add custom extensions (or any other attribute) in schemas (see #160):

Screenshot 2024-08-01 at 12 40 47

Copy link

changeset-bot bot commented Aug 1, 2024

🦋 Changeset detected

Latest commit: 0d9e98e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@scalar/openapi-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

cloudflare-workers-and-pages bot commented Aug 1, 2024

Deploying openapi-parser with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d9e98e
Status: ✅  Deploy successful!
Preview URL: https://e1df81c6.openapi-parser.pages.dev
Branch Preview URL: https://feat-better-openapi-types.openapi-parser.pages.dev

View logs

Copy link

relativeci bot commented Aug 1, 2024

#133 Bundle Size — 74.91KiB (0%).

0d9e98e(current) vs bb10fa5 main#132(baseline)

Bundle metrics  no changes
                 Current
#133
     Baseline
#132
No change  Initial JS 74.91KiB 74.91KiB
No change  Initial CSS 0B 0B
No change  Cache Invalidation 0% 0%
No change  Chunks 45 45
No change  Assets 45 45
No change  Modules 45 45
No change  Duplicate Modules 0 0
No change  Duplicate Code 0% 0%
No change  Packages 0 0
No change  Duplicate Packages 0 0
Bundle size by type  no changes
                 Current
#133
     Baseline
#132
No change  JS 74.91KiB 74.91KiB

Bundle analysis reportBranch feat/better-openapi-typesProject dashboard

@hanspagel hanspagel requested a review from marclave August 1, 2024 11:17
@hanspagel hanspagel changed the title feat: allow typing custom extensions, allow custom extensions in schemas feat: type custom extensions, custom extensions in schemas Aug 1, 2024
Copy link
Member

@marclave marclave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOVE this

@marclave marclave merged commit aec9f22 into main Aug 8, 2024
8 checks passed
@marclave marclave deleted the feat/better-openapi-types branch August 8, 2024 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants