Always expose virtual properties by default

[Lumbendil]

Added support for virtual properties when the exclusion policy is set to "all" by making them allways exposed by default.

[schmittjoh]

There was another PR submitted for this (#144), but this one looks simpler.

Could you add a small test to the base driver test?

[Lumbendil]

I'll do it right now (after I understand fully how it's tested.)

Btw, I noticed that after doing

composer install
phpunit

There are two tests that fail. Is this already known?

[schmittjoh]

Can you try "composer install --dev", maybe we also need to adjust the
minimum stability after latest composer changes.

On Fri, Jul 6, 2012 at 11:10 AM, Roger Llopart Pla <
[email protected]

wrote:

I'll do it right now (after I understand fully how it's tested.)

Btw, I noticed that after doing

composer install
phpunit

There are two tests that fail. Is this already known?

---

Reply to this email directly or view it on GitHub:

#145 (comment)

[Lumbendil]

Already done that, the output of PHPUnit is the following:

There were 2 errors:

1) JMS\SerializerBundle\Tests\Serializer\JsonSerializationTest::testNestedFormErrors
Argument 2 passed to Symfony\Component\Form\Form::__construct() must implement interface Symfony\Component\EventDispatcher\EventDispatcherInterface, none given, called in /home/lumbendil/projects/fashionweb.local/vendor/bundles/JMS/SerializerBundle/Tests/Serializer/BaseSerializationTest.php on line 355 and defined

/home/lumbendil/projects/fashionweb.local/vendor/bundles/JMS/SerializerBundle/vendor/symfony/form/Symfony/Component/Form/Form.php:189
/home/lumbendil/projects/fashionweb.local/vendor/bundles/JMS/SerializerBundle/Tests/Serializer/BaseSerializationTest.php:355

2) JMS\SerializerBundle\Tests\Serializer\XmlSerializationTest::testNestedFormErrors
Argument 2 passed to Symfony\Component\Form\Form::__construct() must implement interface Symfony\Component\EventDispatcher\EventDispatcherInterface, none given, called in /home/lumbendil/projects/fashionweb.local/vendor/bundles/JMS/SerializerBundle/Tests/Serializer/BaseSerializationTest.php on line 355 and defined

/home/lumbendil/projects/fashionweb.local/vendor/bundles/JMS/SerializerBundle/vendor/symfony/form/Symfony/Component/Form/Form.php:189
/home/lumbendil/projects/fashionweb.local/vendor/bundles/JMS/SerializerBundle/Tests/Serializer/BaseSerializationTest.php:355

I'm working on the tests, I've understood how the fixtures are done, so I'll be finished in a moment.

[Lumbendil]

I've managed to implement tests for Annotations YAML and XML, but I'm having issues with the PhpDriver, since it ain't docummented how it works.

I'll commit what i have up to now, It'd be great if you could give me some hints on how to move on from here.

[Lumbendil]

Disgread what I said, I've found it out.

[schmittjoh]

I think exclusion_policy: ALL is missing here.

[Lumbendil]

True, fixing it now.

[Lumbendil]

Anything else needed, or can this PR be merged?

[schmittjoh]

No, looks good :)