Updated YmlDriver to support accessor config and fixed read_only "bug" #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly was assigned, which meant that deserialization would require a public setter for a readonly property (which may not exist, e.g. in generated Doctrine2 entities). Also added support for the accessor_getter and accessor_setter config options in YML, which are supported in the XmlDriver but not in YmlDriver.
…ed by #156 Example: My\Bundle\Entity\Thing: properties: created_at: read_only: true type: DateTime accessor: getter: getCreatedAt setter: setCreatedAt
|
This seems like a duplicate of #154? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue where setAccessor was called before $pMetadata->readOnly was
assigned, which meant that deserialization would require a public setter for a
readonly property (which may not exist, e.g. in generated Doctrine2 entities).
Also added support for the accessor_getter and accessor_setter config options
in YML, which are supported in the XmlDriver but not in YmlDriver.