Added support serialization the nested form errors. #17
+83
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've made some changes: Tests still pass, but let me know if I have broken something. |
|
It works. Thanks. |
|
But it seems for the form need separate the handler, and in it should be logic - serialize only errors or all fields of form. |
|
Not sure I understand what you mean. Could you maybe provide an example? |
|
If do implement the handler instead of FormNormalizer, it will be duplicated with the logic of FormErrorHandler. And in this case for handlers will need to specify the priority, if both handlers will be registered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.