enabled Symfony 3.0 support #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsmith77
force-pushed
the
symfony_3_0
branch
4 times, most recently
from
1dc70a1 to
1f00cea
Compare
| "jms/serializer": "^1.0.0", | ||
| "symfony/framework-bundle": "~2.1" | ||
| "phpoption/phpoption": "^1.0.0", |
There was a problem hiding this comment.
this probably should have been in the jms/serializer
| "jms/serializer": "^1.0.0", | ||
| "symfony/framework-bundle": "~2.1" | ||
| "phpoption/phpoption": "^1.1.0", |
There was a problem hiding this comment.
this probably should also be set jms/serializer but it needs to be here as well or we have to bump the minimal version of jms/serializer to a version that includes this requirement.
|
@schmittjoh would be nice to merge this and tag 1.1 :) |
|
@schmittjoh would love that to happen asap 👍 |
|
👍 it's important to have this merged + a tag so that we can update other dependent bundles (e.g. FOSRestBundle) for 3.0 compat. It's a big domino effect. |
schmittjoh
added a commit
that referenced
this pull request
Nov 10, 2015
enabled Symfony 3.0 support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also tweaked some aspects of the travis configuration and the composer requires