Twig filter access to serializer #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * Basically provides access to JMSSerializer from Twig | ||
| */ | ||
| class Serializer extends \Twig_Extension { |
There was a problem hiding this comment.
Can you suffix this class with "Extension", i.e. "SerializerExtension"?
|
Thanks for this patch. Could you clean up your commits a bit to follow the Symfony2 coding style (especially 4 spaces for indentation)? |
| { | ||
| $this->mockSerializer = $this->getMock('JMS\SerializerBundle\Serializer\SerializerInterface'); | ||
| } | ||
| public function testSerialize() |
There was a problem hiding this comment.
missing empty line between the methods, and the indentation is wrong
|
Thanks for the feedback. Suggested coding standards changed, and naming fixed. I've also added a short bit of documentation to the main doc file. |
schmittjoh
added a commit
that referenced
this pull request
Dec 22, 2011
Twig filter access to serializer
|
Thanks, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a very basic twig extension that provides "wrapper" access to the serializer service via a twig filter.
It allows for
{{ Entity | serialize | raw }}inside twig templatesI'm not sure if I need to setup some other config, or make this optional somehow. Suggestions/comments welcome.