Allow to not skip empty not inline array root node

[goetas]

The current implementation skips the root node for not inline arrays when serializing into XML.

Given:

class User {
    /**
     * @Serializer\XmlList(inline = false, entry = "comment")
     * @Serializer\Type("array")
     */
    public $data = [];
}

The previous output was:

<result/>

The new behaviour is:

<result>
  <data/>
</result>

Should this be considered a BC break?
probably yes

This change is consistent with the existing JSON and YML implementations since the output is

{
  "data": []
}

data: []

[goetas]

Should this be considered a BC break?

probably yes, will add an option to configure it

[schmittjoh]

It seems very marginal, I would be more inclined to just merge it. It only breaks if you literally compare string values, no?

[goetas]

Please wait, will fix it tomorrow. I have some usecases

On 25 Jul 2016 6:41 pm, "Johannes" [email protected] wrote:

It seems very marginal, I would be more inclined to just merge it. It only
breaks if you literally compare string values, no?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#611 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAvaJ_X-QDpJWbvAhJIjAGwsWzkQQxErks5qZOcegaJpZM4JT9YV
.

[goetas]

Added configuration option that allows to chose the default serialization strategy.

class User {
    /**
     * @Serializer\XmlList(inline = false, entry = "comment", skip_when_empty=false)
     * @Serializer\Type("array")
     */
    public $data = [];
}

this will add the new behaviour serializing it into:

<result>
  <data/>
</result>

[goetas]

The last two commits are minor changes:
2d664fa is a minor changes that solves some edge cases when document contains namespaces.

3860411 simplifies the if/else conditions and checks for namespaces difined at node scope, not only at document scope

[schmittjoh]

Do we use this casing for other annotations? I think we already use camelCasing, no?

[goetas]

true, will fix it

[goetas]

done

[goetas]

🎉

[goetas]

thanks!

any plan for a 1.2.0 release?

(there are some PR pretty safe to merge that can be good to include in a hypothetical 1.2 release)