Added support for a third deserialize parameter for the DateTime type #788
Conversation
|
Relates to #787, both will fix the problem I experience in schmittjoh/JMSSerializerBundle#582. |
src/Handler/DateHandler.php
Outdated
| @@ -175,8 +175,8 @@ public function deserializeDateIntervalFromJson(JsonDeserializationVisitor $visi | |||
|
|
|||
| private function parseDateTime($data, array $type, $immutable = false) | |||
| { | |||
| $timezone = isset($type['params'][1]) ? new \DateTimeZone($type['params'][1]) : $this->defaultTimezone; | |||
| $format = $this->getFormat($type); | |||
| $timezone = isset($type['params'][1]) && $type['params'][1] != "" ? new \DateTimeZone($type['params'][1]) : $this->defaultTimezone; | |||
There was a problem hiding this comment.
you can just use !empty instead of isset
| +----------------------------------------------------------+--------------------------------------------------+ | ||
| | DateTime<'format', 'zone'> | PHP's DateTime object (custom format/timezone) | | ||
| +----------------------------------------------------------+--------------------------------------------------+ | ||
| | DateTime<'format', 'zone', 'deserializeFormat'> | PHP's DateTime object (custom format/timezone, | |
There was a problem hiding this comment.
can you specify that is optional? (same for zone since we are editing it)
src/Handler/DateHandler.php
Outdated
| { | ||
| if ($deserialize && isset($type['params'][2])){ |
There was a problem hiding this comment.
space before { (PSR standards)
src/Handler/DateHandler.php
Outdated
| { | ||
| if ($deserialize && isset($type['params'][2])){ | ||
| return $type['params'][2]; |
|
Very appreciated this PR 😄 , I also had to use some workarounds to solve a similar issue |
|
Solved your review notes, and added a simple test. I'm not really experienced with tests, so when it's not sufficient, maybe you can take a look? |
|
@bobvandevijver thanks for your PR. (If you are interested have a look at my version of the testcase https://github.com/schmittjoh/serializer/blob/b92cf25987d0f2bae0817476a117f8b2811a54ef/tests/Handler/DateHandlerTest.php) |
This PR adds an third parameter to the DateTime format for the Type annotation, allowing to use a different deserialization type. This can be useful when only serializing dates in a custom format and you need to have the other fields all zeroed.