test: editable install cover package navigation #535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LecrisUT
commented
Oct 24, 2023
Comment on lines
+72
to
+76
| # Navigate from py_package.py_module to py_package | ||
| value = isolated.execute( | ||
| "import py_pkg.py1_pkg.py1_module; py_pkg.py1_pkg.py1_module.py2_method_b()" | ||
| ) | ||
| assert value == "py2_method_b" |
There was a problem hiding this comment.
@dialecticDolt, I have reproduced your error here
LecrisUT
force-pushed
the
fix/editable_install
branch
from
8368aab to
847013b
Compare
henryiii
force-pushed
the
fix/editable_install
branch
from
847013b to
a398e27
Compare
|
Hmm these are still failing, I guess because they cover the |
LecrisUT
changed the title
LecrisUT
force-pushed
the
fix/editable_install
branch
from
54f65ab to
3af214b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
py1_pkg.py1_module->py2_pkg.py2_module)(ns1)py3_pkg.pya_module->(ns2)py3_pkg.pyb_module)(_c_lib.so)c1_pkg.c1_module->(_c_lib.so)c2_pkg.c2_module;(_c3_lib.so)c3_pkg.c3_module->(_c4_lib.so)c4_pkg.c4_mdoule)shared_pkg.c1_pkg.c1_modulewithc1_pkgandc1_modulein the same.sofile;shared_pkg.c1_pkg.py2_modulewithpy2_modulefrom python)Naming could be a bit cumbersome. Is there a convention or some reusable structure that we can import