Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added before property to container for ordered containers #136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kai-kystverket
Copy link

@kai-kystverket kai-kystverket commented Apr 3, 2025

Added a before property to the container schema to allow ordered executions. This would be implemented as example init container in k8s or depends_on in docker compose.

Description

Added two new fields

  • container: A reference to another container which should be run before
  • status: The status check to decide when to start the container.

What does this PR do?

Implements #104

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

@kai-kystverket kai-kystverket marked this pull request as ready for review April 7, 2025 08:53
@mathieu-benoit
Copy link
Contributor

@astromechza, like discussed let's review and merge this one as it will unlock a lot of good use cases with "initContainers".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants