Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telescope): add nvchad borderless telescope style #75

Merged
merged 6 commits into from
Jun 15, 2024
Merged

feat(telescope): add nvchad borderless telescope style #75

merged 6 commits into from
Jun 15, 2024

Conversation

AlejandroSuero
Copy link
Contributor

@scottmckendry I think it would be a good thing to allow for a separation style borderless telescope, like NvChad "borderless", but allowing for this to be opt-out like catppuccin does in their integrations section.

nvchad-borderless-style-addition.mp4

Note

I made it so the changes are compatible with the current way of configuring the colorscheme.

In the video the options are { ..., theme = "nvchad" } but I changed after recording it to style

It can be change to be a BREAKING CHANGE and have it like:

require("cyberdream").setup({
  -- ...
  telescope = {
    borderless = true,
    style = "nvchad",
  },
  -- ...
})

The good thing about adding this PR (in my opinion) is that it leads to having styles like "nvchad_inversed", and do one that it will keep the base borderless` but light up the results section for example.

@AlejandroSuero
Copy link
Contributor Author

@scottmckendry for the blueish theme, I used this in my nvim-config:

require("cyberdream").setup({
  theme = {
    overrides = function(colors)
      TelescopePromptPrefix = { fg = colors.blue },
      TelescopeMatching = { fg = colors.cyan },
      TelescopeResultsTitle = { fg = colors.blue },
      TelescopePromptCounter = { fg = colors.cyan },
      TelescopePromptTitle = { fg = colors.bg, bg = colors.blue, bold = true },
    end,
  },
})

And here is how it looks in action:

telescope-blue-theme.mp4

@scottmckendry
Copy link
Owner

This is a very clever implementation! Great work, yet again @AlejandroSuero!

I've added another style to represent the default value. It makes it more obvious that there's a difference between nvchad and the old default styling. It will be cool having multiple styles to choose from in future 🚀

@scottmckendry scottmckendry merged commit c1085d7 into scottmckendry:main Jun 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants